bn_nist: fix strict aliasing problem#18258
Closed
paulidale wants to merge 2 commits intoopenssl:masterfrom
Closed
Conversation
As of clang-14 the strict aliasing is causing code to magically disappear. By explicitly inlining the code, the aliasing problem evaporates. Fixes openssl#18225
paulidale
added
branch: master
github-actions
bot
added
the
severity: fips change
t8m
approved these changes
May 6, 2022
Contributor
|
This is the LibreSSL patch for this issue: https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libcrypto/bn/bn_nist.c.diff?r1=1.19&r2=1.20 |
Contributor
Author
|
Thanks for the counterpoint @guidovranken, @t8m any thoughts on which approach you prefer? |
Member
|
I would rather lower the global optimization level for this compiler version. |
Contributor
Author
|
We'd need to drop it to -O1 or less. -O2 adds -fstrict-aliasing. We could single this file out for -fno-strict-aliasing, or perhaps just build everything with -fno-strict-aliasing since it isn't going to hurt the assembly code. |
Member
|
I prefer the fix as is in this PR. It fixes the UB as it keeps the union visible in the macro. |
mattcaswell
approved these changes
May 9, 2022
t-j-h
approved these changes
May 9, 2022
t-j-h
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Contributor
Author
|
Merged. |
openssl-machine
pushed a commit
that referenced
this pull request
May 10, 2022
As of clang-14 the strict aliasing is causing code to magically disappear. By explicitly inlining the code, the aliasing problem evaporates. Fixes #18225 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #18258)
openssl-machine
pushed a commit
that referenced
this pull request
May 10, 2022
As of clang-14 the strict aliasing is causing code to magically disappear. By explicitly inlining the code, the aliasing problem evaporates. Fixes #18225 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #18258) (cherry picked from commit 8712db5)
Member
|
Any reason this wasn't backported to 1.1.1? The original issue says that 1.1.1 is also affected |
mattcaswell
pushed a commit
to mattcaswell/openssl
that referenced
this pull request
Aug 3, 2022
As of clang-14 the strict aliasing is causing code to magically disappear. By explicitly inlining the code, the aliasing problem evaporates. Fixes openssl#18225 Backport of openssl#18258 to 1.1.1.
Member
I created a backport in #18948 |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 17, 2022
As of clang-14 the strict aliasing is causing code to magically disappear. By explicitly inlining the code, the aliasing problem evaporates. Fixes #18225 Backport of #18258 to 1.1.1. Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #18948)
bernd-edlinger
pushed a commit
to bernd-edlinger/openssl
that referenced
this pull request
Sep 9, 2022
As of clang-14 the strict aliasing is causing code to magically disappear. By explicitly inlining the code, the aliasing problem evaporates. Fixes openssl#18225 Backport of openssl#18258 to 1.1.1. Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#18948) (cherry picked from commit 6246649)
bernd-edlinger
pushed a commit
to bernd-edlinger/openssl
that referenced
this pull request
Sep 9, 2022
As of clang-14 the strict aliasing is causing code to magically disappear. By explicitly inlining the code, the aliasing problem evaporates. Fixes openssl#18225 Backport of openssl#18258 to 1.1.1. Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#18948) (cherry picked from commit 6246649)
5 tasks
a-kromm-rogii
pushed a commit
to a-kromm-rogii/openssl
that referenced
this pull request
Mar 14, 2025
As of clang-14 the strict aliasing is causing code to magically disappear. By explicitly inlining the code, the aliasing problem evaporates. Fixes openssl#18225 Backport of openssl#18258 to 1.1.1. Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#18948)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of clang-14 the strict aliasing is causing code to magically disappear.
By explicitly inlining the code, the aliasing problem evaporates.
Fixes #18225
I'd like to wait until llvm/llvm-project#55255 gets commented on before commiting this.