Skip to content

Update the SSL time APIs#17658

Open
yanli999 wants to merge 1 commit intoopenssl:masterfrom
yanli999:sslTimeissue
Open

Update the SSL time APIs#17658
yanli999 wants to merge 1 commit intoopenssl:masterfrom
yanli999:sslTimeissue

Conversation

@yanli999
Copy link

@yanli999 yanli999 commented Feb 8, 2022 •
edited
Loading

Checklist
  • documentation is added or updated
  • tests are added or updated

@yanli999 yanli999 changed the title fix the ssl time length issue Fix the ssl time set and get api Feb 8, 2022
@yanli999
Copy link
Author

yanli999 commented Feb 8, 2022

The time of ssl connect is "long" type before ,it was update to "time_t" type for 2038 year or latter , update the SSL_SESSION_get_time() , SSL_SESSION_set_time() and SSL_CTX_flush_sessions() for adapter this change.

@yanli999 yanli999 changed the title Fix the ssl time set and get api Update the SSL APIs SSL_SESSION_get_time(), SSL_SESSION_set_time() and SSL_CTX_flush_sessions() for adapt to "time_t" structure. Feb 8, 2022
@yanli999 yanli999 changed the title Update the SSL APIs SSL_SESSION_get_time(), SSL_SESSION_set_time() and SSL_CTX_flush_sessions() for adapt to "time_t" structure. Update the SSL time APIs Feb 8, 2022
@t8m t8m added the triaged: feature The issue/pr requests/adds a feature label Feb 8, 2022
@t8m
Copy link
Member

t8m commented Feb 8, 2022

This is an API breaking change that cannot be done in 3.1.

@t8m t8m added this to the 4.0.0 milestone Feb 8, 2022
@yanli999 yanli999 force-pushed the sslTimeissue branch 2 times, most recently from bff1e84 to 65b255d Compare February 9, 2022 02:03
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Feb 9, 2022
@yanli999
Update the SSL APIs SSL_SESSION_get_time(),SSL_SESSION_set_time() and
522c806 
SSL_CTX_flush_sessions() for adapt to "time_t" structure.
@github-actions github-actions bot removed the severity: fips change The pull request changes FIPS provider sources label Feb 9, 2022
@yanli999
Copy link
Author

yanli999 commented Feb 10, 2022

Hi Tomáš Mráz,
Does this commit will be merge later ? I want to pause two week because I want do more test for it. should I close this pull request?

@t-j-h
Copy link
Member

t-j-h commented Feb 10, 2022

An alternative approach is to introduce new functions which use time_t and then we can deprecated the existing functions.
That would not be an API-breaking change that requires waiting for a future release as @t8m as noted.

This PR won't be merged in its current form until we are at a release where a breaking API change is permitted so you don't need to worry that someone will merge this "early" without your testing being completed.

@bernd-edlinger bernd-edlinger mentioned this pull request Feb 19, 2022
Closed
@tmshort
Copy link
Contributor

tmshort commented Mar 1, 2022

Alternative proposal: #17786 (it's a WIP).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

triaged: feature The issue/pr requests/adds a feature

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yanli999 @t8m @t-j-h @tmshort