Skip to content

Comments

apps: Add option -no_ems to s_client/s_server command line.#17597

Closed
hou2gou wants to merge 1 commit intoopenssl:masterfrom
hou2gou:no_ems
Closed

apps: Add option -no_ems to s_client/s_server command line.#17597
hou2gou wants to merge 1 commit intoopenssl:masterfrom
hou2gou:no_ems

Conversation

@hou2gou
Copy link
Contributor

@hou2gou hou2gou commented Jan 26, 2022

The option SSL_OP_NO_EXTENDED_MASTER_SECRET add in #3910.
And it is valid for versions below (D)TLS 1.2.

Checklist
  • documentation is added or updated
  • tests are added or updated

The option SSL_OP_NO_EXTENDED_MASTER_SECRET add in openssl#3910.
And it is valid for versions below (D)TLS 1.2.
@hou2gou
Copy link
Contributor Author

hou2gou commented Jan 26, 2022

Application scenario: Provide a test command line tool for SSL proxy service, which needs to be compatible with devices from various manufacturers.

@t8m t8m added branch: master Applies to master branch triaged: feature The issue/pr requests/adds a feature labels Jan 26, 2022
@t8m t8m added the approval: review pending This pull request needs review by a committer label Jan 26, 2022
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 26, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 27, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jan 28, 2022
The option SSL_OP_NO_EXTENDED_MASTER_SECRET was added in #3910.
And it is valid for versions below (D)TLS 1.2.

Reviewed-by: Dmitry Belyavskiy <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #17597)
@t8m
Copy link
Member

t8m commented Jan 28, 2022

Merged to master branch. Thank you for your contribution.

@t8m t8m closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch triaged: feature The issue/pr requests/adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants