crypto/bio: drop float formating for UEFI#17547
Closed
kraxel wants to merge 2 commits intoopenssl:masterfrom
Closed
crypto/bio: drop float formating for UEFI#17547kraxel wants to merge 2 commits intoopenssl:masterfrom
kraxel wants to merge 2 commits intoopenssl:masterfrom
Conversation
This reverts commit 328bf5a. Turned out it isn't that simple, the fix is incomplete. So revert and try again with another approach. Signed-off-by: Gerd Hoffmann <[email protected]>
t8m
reviewed
Jan 19, 2022
crypto/bio/bio_print.c
Outdated
Member
There was a problem hiding this comment.
Why the uppercase? I'd prefer erroring out with return 0 instead of assert.
Contributor
There was a problem hiding this comment.
We don't have asserts in the library. An error return here is appropriate.
Contributor
Author
There was a problem hiding this comment.
Why the uppercase? I'd prefer erroring out with return 0 instead of assert.
The other branch handles uppercase too.
t8m
added
branch: 3.0
Contributor
Author
|
The test failure looks like some temporary network issue, is there some way to re-run that test? |
t8m
approved these changes
Jan 19, 2022
t8m
added
the
approval: review pending
paulidale
approved these changes
Jan 20, 2022
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
Approved with the line deleted.
paulidale
added
approval: done
Using floating point is not supported in UEFI and can cause build problems, for example due to SSE being disabled and x64 calling convention passing floats in SSE registers. Avoid those problems by not compiling the formating code for floating point numbers. Signed-off-by: Gerd Hoffmann <[email protected]>
paulidale
approved these changes
Jan 20, 2022
t8m
approved these changes
Jan 20, 2022
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 21, 2022
This reverts commit 328bf5a. Turned out it isn't that simple, the fix is incomplete. So revert and try again with another approach. Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #17547)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 21, 2022
Using floating point is not supported in UEFI and can cause build problems, for example due to SSE being disabled and x64 calling convention passing floats in SSE registers. Avoid those problems by not compiling the formating code for floating point numbers. Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #17547)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 21, 2022
This reverts commit 328bf5a. Turned out it isn't that simple, the fix is incomplete. So revert and try again with another approach. Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #17547) (cherry picked from commit 619c9ba)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 21, 2022
Using floating point is not supported in UEFI and can cause build problems, for example due to SSE being disabled and x64 calling convention passing floats in SSE registers. Avoid those problems by not compiling the formating code for floating point numbers. Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #17547) (cherry picked from commit f59d72f)
Member
|
Merged to master and 3.0 branches. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.