CMS, PKCS7, and CRMF: simplify use of EVP_PKEY_decrypt() by helper function#17354
Closed
DDvO wants to merge 3 commits intoopenssl:masterfrom
Closed
CMS, PKCS7, and CRMF: simplify use of EVP_PKEY_decrypt() by helper function#17354DDvO wants to merge 3 commits intoopenssl:masterfrom
EVP_PKEY_decrypt() by helper function#17354DDvO wants to merge 3 commits intoopenssl:masterfrom
Conversation
DDvO
added
triaged: bug
DDvO
added
triaged: refactor
DDvO
changed the title
OSSL_CRMF_ENCRYPTEDVALUE_get1_encCertEVP_PKEY_decrypt() by helper function
DDvO
force-pushed
the
fix_OSSL_CRMF_get1_encCert
branch
from
3c0c9f9 to
e6eb37c
Compare
DDvO
added
approval: review pending
github-actions
bot
added
the
severity: fips change
DDvO
force-pushed
the
fix_OSSL_CRMF_get1_encCert
branch
from
e6eb37c to
cdad657
Compare
…nction Also remove needless constant_time_* and ERR_clear_error() calls from OSSL_CRMF_ENCRYPTEDVALUE_get1_encCert().
DDvO
force-pushed
the
fix_OSSL_CRMF_get1_encCert
branch
from
cdad657 to
3447895
Compare
DDvO
added
the
triaged: cleanup
t8m
approved these changes
May 29, 2023
beldmit
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
May 30, 2023
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: David von Oheimb <[email protected]> (Merged from #17354)
openssl-machine
pushed a commit
that referenced
this pull request
May 30, 2023
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: David von Oheimb <[email protected]> (Merged from #17354)
openssl-machine
pushed a commit
that referenced
this pull request
May 30, 2023
…nction Also remove needless constant_time_* and ERR_clear_error() calls from OSSL_CRMF_ENCRYPTEDVALUE_get1_encCert(). Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: David von Oheimb <[email protected]> (Merged from #17354)
Contributor
Author
MrE-Fog
pushed a commit
to MrE-Fog/opensslxxixx
that referenced
this pull request
Jun 4, 2023
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: David von Oheimb <[email protected]> (Merged from openssl/openssl#17354)
MrE-Fog
pushed a commit
to MrE-Fog/opensslxxixx
that referenced
this pull request
Jun 4, 2023
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: David von Oheimb <[email protected]> (Merged from openssl/openssl#17354)
MrE-Fog
pushed a commit
to MrE-Fog/opensslxxixx
that referenced
this pull request
Jun 4, 2023
…nction Also remove needless constant_time_* and ERR_clear_error() calls from OSSL_CRMF_ENCRYPTEDVALUE_get1_encCert(). Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: David von Oheimb <[email protected]> (Merged from openssl/openssl#17354)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of this has originally been carved out from #15283.
EVP_PKEY_decrypt()within libcrypto, where further improvements such as those as discussed in Use ofEVP_PKEY_decrypt()should be more secure #17319 can done there, at just one place for all these uses.ssl/statem/statem_srvr.c: clean up handling ofEVP_PKEY_decrypt()outlenOSSL_CRMF_ENCRYPTEDVALUE_get1_encCert(): remove needlessconstant_time_*andERR_clear_error()calls, as discussed in Fix spurious error queue entries while loading private keys #15283 (review)cmp_http.c: Remove obsolete comment w.r.t.ERR_clear_error()