Fix a deadlock in OBJ_NAME_add#17236
Closed
bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Closed
Fix a deadlock in OBJ_NAME_add#17236bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Conversation
bernd-edlinger
added
the
branch: 1.1.1
This happened after an out of memory error: CRYPTO_THREAD_write_lock may hang in OBJ_NAME_add.
bernd-edlinger
force-pushed
the
fix_deadlock_in_init_crypto_1
branch
from
ce52640 to
bb105ac
Compare
bernd-edlinger
changed the title
mattcaswell
reviewed
Dec 8, 2021
| if (names_lh == NULL) { | ||
| CRYPTO_THREAD_lock_free(obj_lock); | ||
| obj_lock = NULL; | ||
| } |
Member
There was a problem hiding this comment.
This part of the change does not appear to be in master
Member
Author
There was a problem hiding this comment.
okay, this is of course only a memory leak, would you support having this in master?
Member
There was a problem hiding this comment.
would you support having this in master?
Yes.
t8m
approved these changes
Dec 8, 2021
t8m
added
approval: done
mattcaswell
approved these changes
Dec 8, 2021
paulidale
approved these changes
Dec 9, 2021
openssl-machine
removed
the
approval: done
Collaborator
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
Member
Author
|
Merged to 1.1.1 as ca607d6. Thanks! |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 9, 2021
This happened after an out of memory error: CRYPTO_THREAD_write_lock may hang in OBJ_NAME_add. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #17236)
baentsch
added a commit
to open-quantum-safe/openssl
that referenced
this pull request
Jun 23, 2022
This fixes a deadlock after an out of memory error
this is for 1.1.1 only, since master seems to have this already fixed.