Skip to content

Comments

Windows CI: explicitly use windows-2019 instead of using windows-latest#17234

Closed
t8m wants to merge 1 commit intoopenssl:masterfrom
t8m:windows-ci-update-2
Closed

Windows CI: explicitly use windows-2019 instead of using windows-latest#17234
t8m wants to merge 1 commit intoopenssl:masterfrom
t8m:windows-ci-update-2

Conversation

@t8m
Copy link
Member

@t8m t8m commented Dec 8, 2021

The windows-latest is the same as windows-2019 currently but we do not want to run two identical builds once windows-latest is switched to mean windows-2022.

@t8m t8m added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Applies to openssl-3.0 branch labels Dec 8, 2021
@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 9, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 10, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Dec 10, 2021
openssl-machine pushed a commit that referenced this pull request Dec 10, 2021
Reviewed-by: Shane Lontis <[email protected]>
(Merged from #17234)

(cherry picked from commit c37ebbd)
@t8m
Copy link
Member Author

t8m commented Dec 10, 2021

Merged to master and 3.0 branches. Thank you for the review.

@t8m t8m closed this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants