Skip to content

Comments

OBJ_obj2txt(): fix off-by-one documentation of the result - backport to 1.1.1#17221

Closed
DDvO wants to merge 2 commits intoopenssl:OpenSSL_1_1_1-stablefrom
siemens:fix_OBJ_obj2txt_doc_1.1.1
Closed

OBJ_obj2txt(): fix off-by-one documentation of the result - backport to 1.1.1#17221
DDvO wants to merge 2 commits intoopenssl:OpenSSL_1_1_1-stablefrom
siemens:fix_OBJ_obj2txt_doc_1.1.1

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Dec 7, 2021

This backports #17189 to 1.1.1.
Doing so, I found that part of the reason why a cherry-pick did not apply cleanly was that the file still used B<...> for parameter names.
So for consistency I changed all remaining ones of those B<...> to I<...>, in a separate commit.

@DDvO DDvO added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) triaged: documentation The issue/pr deals with documentation (errors) labels Dec 7, 2021
@DDvO DDvO requested a review from t8m December 7, 2021 13:08
@DDvO DDvO mentioned this pull request Dec 7, 2021
Closed
@t8m t8m added the approval: done This pull request has the required number of approvals label Dec 7, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 8, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Dec 8, 2021

This pull request is ready to merge

@DDvO
Copy link
Contributor Author

DDvO commented Dec 9, 2021

Merged to 1.1.1 - thanks @t8m

@DDvO DDvO closed this Dec 9, 2021
openssl-machine pushed a commit that referenced this pull request Dec 9, 2021
@DDvO
OBJ_nid2obj.pod: Replace remaining 'B<' by 'I<' were appropriate
7a045a4 
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #17221)
@DDvO
Copy link
Contributor Author

DDvO commented Jan 3, 2022

I just found that I had forgotten to push the 2nd commit 3c56057 - done now.

baentsch added a commit to open-quantum-safe/openssl that referenced this pull request Jun 23, 2022
@baentsch @luyahan
@devnexen @davidben @t8m @paulidale @mattcaswell @levitte @ueno @ischwarze @bbbrumley @tmshort @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @beldmit @PeiweiHu @x2018 @allanjude @DDvO @dongbeiouba @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau @juergenchrist @reaperhulk @basavesh @frasertweedale
Upstream 111p merge (#375