Skip to content

OBJ_obj2txt(): fix off-by-one documentation of the result - backport to 3.0 and 1.1.1#17189

Closed
DDvO wants to merge 1 commit intoopenssl:openssl-3.0from
siemens:fix_OBJ_obj2txt_doc_3.0
Closed

OBJ_obj2txt(): fix off-by-one documentation of the result - backport to 3.0 and 1.1.1#17189
DDvO wants to merge 1 commit intoopenssl:openssl-3.0from
siemens:fix_OBJ_obj2txt_doc_3.0

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Dec 3, 2021

This backports the doc improvements of #17188 to 3.0 and 1.1.1.

@DDvO DDvO added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) approval: otc review pending triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Applies to openssl-3.0 branch labels Dec 3, 2021
@DDvO DDvO requested a review from t8m December 3, 2021 14:20
@DDvO DDvO changed the title OBJ_obj2txt(): fix off-by-one documentation of the result OBJ_obj2txt(): fix off-by-one documentation of the result - backport to 3.0 and 1.1.1 Dec 3, 2021
@DDvO DDvO force-pushed the fix_OBJ_obj2txt_doc_3.0 branch from fba7b90 to 633efba Compare December 3, 2021 15:00
@DDvO DDvO force-pushed the fix_OBJ_obj2txt_doc_3.0 branch from 633efba to 3d1cb74 Compare December 3, 2021 15:02
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: otc review pending labels Dec 3, 2021
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Dec 4, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Dec 4, 2021
openssl-machine pushed a commit that referenced this pull request Dec 7, 2021
This backports the doc improvements of #17188.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #17189)
@t8m
Copy link
Member

t8m commented Dec 7, 2021

Merged to 3.0. This does not apply cleanly to 1.1.1 so that will require a separate PR. @DDvO would you please create one?

@t8m t8m closed this Dec 7, 2021
@t8m t8m removed the branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) label Dec 7, 2021
@DDvO
Copy link
Contributor Author

DDvO commented Dec 7, 2021

Merged to 3.0.

Thanks.

This does not apply cleanly to 1.1.1 so that will require a separate PR. @DDvO would you please create one?

Yep, done in #17221.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.0 Applies to openssl-3.0 branch triaged: documentation The issue/pr deals with documentation (errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants