OBJ_obj2txt(): fix off-by-one documentation of the result#17188
Closed
DDvO wants to merge 2 commits intoopenssl:masterfrom
Closed
OBJ_obj2txt(): fix off-by-one documentation of the result#17188DDvO wants to merge 2 commits intoopenssl:masterfrom
OBJ_obj2txt(): fix off-by-one documentation of the result#17188DDvO wants to merge 2 commits intoopenssl:masterfrom
Conversation
DDvO
added
branch: master
DDvO
changed the title
OBJ_obj2txt() fix off-by-one result; improve documentationOBJ_obj2txt() fix off-by-one documentation of the result
DDvO
changed the title
OBJ_obj2txt() fix off-by-one documentation of the resultOBJ_obj2txt(): fix off-by-one documentation of the result
t8m
added
the
triaged: cleanup
t8m
approved these changes
Dec 3, 2021
Member
t8m
left a comment
t8m
left a comment
There was a problem hiding this comment.
OK for master. The code cleanup part should not be backported so please open new PR against 3.0 and 1.1.1 for the documentation only fix.
t8m
added
approval: done
t8m
reviewed
Dec 3, 2021
DDvO
added a commit
to siemens/openssl
that referenced
this pull request
Dec 3, 2021
This backports the doc improvements of openssl#17188.
Also remove the outdated BUGS section and fix the coding style of the function.
t8m
approved these changes
Dec 3, 2021
t8m
approved these changes
Dec 3, 2021
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
paulidale
approved these changes
Dec 6, 2021
t8m
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Dec 7, 2021
This backports the doc improvements of #17188. Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #17189)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 7, 2021
Also remove the outdated BUGS section and fix the coding style of the function. Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #17188)
Member
|
Merged to master. Thank you. |
DDvO
added a commit
to siemens/openssl
that referenced
this pull request
Dec 7, 2021
This backports the doc improvements of openssl#17188.
DDvO
added a commit
to siemens/openssl
that referenced
this pull request
Jan 3, 2022
This backports the doc improvements of openssl#17188. (cherry picked from commit e36d10925396b6519e1abd338e1ef62cd5b1c9e6)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 3, 2022
This backports the doc improvements of #17188. Reviewed-by: Tomas Mraz <[email protected]> (cherry picked from commit e36d10925396b6519e1abd338e1ef62cd5b1c9e6)
Although documented otherwise,
the function result value does not count the trailing NUL char.
At first, I corrected the code according to the doc, but then a couple of tests failed,
thus it turned out some code depends on the weird behavior contradicting the doc.
So I adapted the doc according to the behavior,
pointing out that the result does not count the trailing NUL character,
and just improved the coding style.
The BUGS section given for that function was outdated, so removed that.
Did also some further related doc improvements.
This pertains also to 3.0 and 1.1.1.