Skip to content

Comments

Fix ssl_free() and thus BIO_free() to respect BIO_NOCLOSE #16688 - backport to 1.1.1#17135

Closed
DDvO wants to merge 2 commits intoopenssl:OpenSSL_1_1_1-stablefrom
siemens:fix_ssl_free_BIO_NOCLOSE-1.1.1
Closed

Fix ssl_free() and thus BIO_free() to respect BIO_NOCLOSE #16688 - backport to 1.1.1#17135
DDvO wants to merge 2 commits intoopenssl:OpenSSL_1_1_1-stablefrom
siemens:fix_ssl_free_BIO_NOCLOSE-1.1.1

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Nov 25, 2021

Backport most of #16688, namely

  • the fix of the BIO_NOCLOSE issue
  • the improvements of BIO_f_ssl.pod

to 1.1.1

@DDvO DDvO added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) approval: otc review pending triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors) labels Nov 25, 2021
@DDvO DDvO mentioned this pull request Nov 25, 2021
Closed
@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: otc review pending labels Nov 25, 2021
@DDvO
Copy link
Contributor Author

DDvO commented Nov 26, 2021

Thanks @paulidale for the quick approval.

BTW, I wonder why there is still the label "branch 1.0.2":
Would it make any sense to backport PRs like this also to 1.0.2 or 1.1.0?

@paulidale
Copy link
Contributor

paulidale commented Nov 26, 2021

1.0.2 is still supported for premium support customers.

@openssl-machine
Copy link
Collaborator

openssl-machine commented Nov 27, 2021

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@DDvO
Copy link
Contributor Author

DDvO commented Dec 3, 2021

@merged to 1.1.1 - thanks @paulidale

@DDvO DDvO closed this Dec 3, 2021
openssl-machine pushed a commit that referenced this pull request Dec 3, 2021
@DDvO
Fix ssl_free() and thus BIO_free() to respect BIO_NOCLOSE
f623a68 
Reviewed-by: Paul Dale <[email protected]>
(Merged from #17135)
openssl-machine pushed a commit that referenced this pull request Dec 3, 2021
@DDvO
BIO_f_ssl.pod: Make clear where an SSL BIOs are expected as an argument
54c3583 
Reviewed-by: Paul Dale <[email protected]>
(Merged from #17135)
baentsch added a commit to open-quantum-safe/openssl that referenced this pull request Jun 23, 2022
@baentsch @luyahan
@devnexen @davidben @t8m @paulidale @mattcaswell @levitte @ueno @ischwarze @bbbrumley @tmshort @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @beldmit @PeiweiHu @x2018 @allanjude @DDvO @dongbeiouba @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau @juergenchrist @reaperhulk @basavesh @frasertweedale
Upstream 111p merge (#375