TEST: Enable and fix test_bn2padded() in test/bntest.c#17133
TEST: Enable and fix test_bn2padded() in test/bntest.c#17133levitte wants to merge 2 commits intoopenssl:masterfrom
Conversation
This looks like old code, written when the padded variety of BN_bn2bin() was developped, and disabled by default... and forgotten. A few simple changes to update it to the current API is all that was needed to enable it.
levitte
added
branch: master
|
I see this as a bug in |
|
CI failure is relevant. |
Fixed |
t8m
added
approval: done
|
Approved for master. I am not sure about 3.0. Probably OTC needs to decide. |
t8m
added
the
hold: discussion
|
Question for OTC to decide: Is adding a new test or fixing and enabling a broken old one a bug fix eligible for stable releases? |
|
Adding a new test is against policy. This feels like it's a new test even though the code was there, it's conditioned away. |
|
For me, it's quite clear cut. That test was supposed to do something, but did nothing, i.e. it fails to do what it was supposed to do. Bug. That it's graceful about its failure to do something doesn't matter in my mind. But OK, OTC decision in the end. |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
|
Merged into master: 23750f6 TEST: Enable and fix test_bn2padded() in test/bntest.c |
This looks like old code, written when the padded variety of BN_bn2bin() was developped, and disabled by default... and forgotten. A few simple changes to update it to the current API is all that was needed to enable it. Reviewed-by: Tomas Mraz <[email protected]> (Merged from #17133)
|
OTC: This is allowed for backport to 3.0 and 1.1.1 |
mattcaswell
removed
the
hold: discussion
This looks like old code, written when the padded variety of BN_bn2bin() was developped, and disabled by default... and forgotten. A few simple changes to update it to the current API is all that was needed to enable it. Reviewed-by: Tomas Mraz <[email protected]> (Merged from #17133) (cherry picked from commit 23750f6)
This looks like old code, written when the padded variety of BN_bn2bin() was developped, and disabled by default... and forgotten. A few simple changes to update it to the current API is all that was needed to enable it. Reviewed-by: Tomas Mraz <[email protected]> (Merged from #17133) (cherry picked from commit 23750f6)
This looks like old code, written when the padded variety of BN_bn2bin()
was developped, and disabled by default... and forgotten.
A few simple changes to update it to the current API is all that was
needed to enable it.