Skip to content

Comments

DOC: Add a few previously documented functions [1.1.1]#17093

Closed
levitte wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
levitte:fix-17091-111
Closed

DOC: Add a few previously documented functions [1.1.1]#17093
levitte wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
levitte:fix-17091-111

Conversation

@levitte
Copy link
Member

@levitte levitte commented Nov 21, 2021

d2i_X509_bio(), d2i_X509_fp(), i2d_X509_bio(), and i2d_X509_fp()
were documented in OpenSSL 1.0.2. In a grand unification of the
documentation of (almost) all d2i and i2d functions, these were
dropped, most likely by mistake.

This simply adds them back.

Fixes #17091

d2i_X509_bio(), d2i_X509_fp(), i2d_X509_bio(), and i2d_X509_fp()
were documented in OpenSSL 1.0.2.  In a grand unification of the
documentation of (almost) all d2i and i2d functions, these were
dropped, most likely by mistake.

This simply adds them back.

Fixes openssl#17091
@levitte levitte added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) approval: review pending This pull request needs review by a committer labels Nov 21, 2021
@levitte levitte changed the title DOC: Add a few previously documented functions DOC: Add a few previously documented functions [1.1.1] Nov 21, 2021
@t8m t8m added approval: done This pull request has the required number of approvals triaged: documentation The issue/pr deals with documentation (errors) and removed approval: review pending This pull request needs review by a committer labels Nov 22, 2021
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Nov 23, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Nov 23, 2021
@levitte
Copy link
Member Author

levitte commented Nov 23, 2021

Merged

6052078 DOC: Add a few previously documented functions

@levitte levitte closed this Nov 23, 2021
@levitte levitte deleted the fix-17091-111 branch November 23, 2021 18:40
openssl-machine pushed a commit that referenced this pull request Nov 23, 2021
d2i_X509_bio(), d2i_X509_fp(), i2d_X509_bio(), and i2d_X509_fp()
were documented in OpenSSL 1.0.2.  In a grand unification of the
documentation of (almost) all d2i and i2d functions, these were
dropped, most likely by mistake.

This simply adds them back.

Fixes #17091

Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #17093)