Detect arm64-*-*bsd and enable assembly optimizations#17084
Closed
allanjude wants to merge 1 commit intoopenssl:masterfrom
Closed
Detect arm64-*-*bsd and enable assembly optimizations#17084allanjude wants to merge 1 commit intoopenssl:masterfrom
allanjude wants to merge 1 commit intoopenssl:masterfrom
Conversation
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Nov 20, 2021
Upstream: * openssl/openssl#17082 * openssl/openssl#17084 PR: 259937 Submitted by: allanjude Differential Revision: https://reviews.freebsd.org/D33062
t8m
added
branch: master
Member
|
I am not sure this is acceptable with CLA: trivial. Would you please consider signing a regular CLA? https://www.openssl.org/policies/cla.html |
paulidale
approved these changes
Nov 24, 2021
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
Border line on the trivial. A CLA is the best way forwards.
Otherwise it looks good.
paulidale
added
the
approval: review pending
allanjude
force-pushed
the
freebsd_aarch_build
branch
from
1bd08d3 to
3d14d13
Compare
openssl-machine
added
the
hold: cla required
Contributor
Author
|
I've signed an ICLA |
openssl-machine
removed
the
hold: cla required
Contributor
|
CLA is good. |
t8m
approved these changes
Nov 25, 2021
t8m
added
approval: done
ocochard
pushed a commit
to ocochard/freebsd-ports
that referenced
this pull request
Nov 25, 2021
Upstream: * openssl/openssl#17082 * openssl/openssl#17084 PR: 259937 Submitted by: allanjude Differential Revision: https://reviews.freebsd.org/D33062
Contributor
|
Merged to master, thanks for the contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 26, 2021
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #17084)
Member
|
This needs to be cherry-picked to 3.0 when merging #17085 to avoid regression. |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
Contributor
|
Agreed. |
Member
|
Cherry picked to 3.0 branch. |
openssl-machine
pushed a commit
that referenced
this pull request
May 5, 2022
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #17084) (cherry picked from commit 8e22f9d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLA: trivial