Fix detection of ARMv7 and ARM64 CPU features on FreeBSD#17079
Closed
allanjude wants to merge 1 commit intoopenssl:masterfrom
Closed
Fix detection of ARMv7 and ARM64 CPU features on FreeBSD#17079allanjude wants to merge 1 commit intoopenssl:masterfrom
allanjude wants to merge 1 commit intoopenssl:masterfrom
Conversation
OpenSSL assumes AT_HWCAP = 16 (as on Linux), but on FreeBSD AT_HWCAP = 25 OpenSSL calls elf_auxv_info() with AT_CANARY which returns ENOENT resulting in all ARM acceleration features being disabled. CLA: trivial
Contributor
Author
|
Would it be preferable to instead do something like: And then use AT_HWCAP to avoid the FreeBSD specific ifdefs? |
Member
Yeah, that would look better to me. |
Contributor
Author
|
I've opened a different pull request for the alternative version, I agree it is cleaner: #17082 |
Member
|
Closing in favor of #17082 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL assumes AT_HWCAP = 16 (as on Linux), but on FreeBSD AT_HWCAP = 25
OpenSSL calls elf_auxv_info() with AT_CANARY which returns ENOENT
resulting in all ARM acceleration features being disabled.
CLA: trivial
Checklist