Skip to content

Comments

ERR: Add a missing common reason string#17069

Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
levitte:missing-common-reason-text-202111
Closed

ERR: Add a missing common reason string#17069
levitte wants to merge 1 commit intoopenssl:masterfrom
levitte:missing-common-reason-text-202111

Conversation

@levitte
Copy link
Member

@levitte levitte commented Nov 19, 2021

There was no string present for ERR_R_PASSED_INVALID_ARGUMENT

@levitte
ERR: Add a missing common reason string
35bbd75 
There was no string present for ERR_R_PASSED_INVALID_ARGUMENT
@levitte levitte added branch: 3.0 Applies to openssl-3.0 branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Nov 19, 2021
@levitte levitte mentioned this pull request Nov 19, 2021
Closed
@DDvO
Copy link
Contributor

DDvO commented Nov 19, 2021

This addition is incomplete and meanwhile superseded by the improved #17056.

@levitte
Copy link
Member Author

levitte commented Nov 19, 2021

This addition is incomplete and meanwhile superseded by the improved #17056.

Before closing, I want to double check the state of 1.1.1, which this PR targets as well

@DDvO DDvO removed branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch labels Nov 22, 2021
DDvO
DDvO approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@DDvO DDvO left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to backport #17056 to 1.1.1 in this (reduced) form.

@DDvO DDvO added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 22, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 23, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Nov 23, 2021

This pull request is ready to merge

@DDvO
Copy link
Contributor

DDvO commented Nov 23, 2021

Pushed to 1.1.1 - thanks @levitte

@DDvO DDvO closed this Nov 23, 2021
openssl-machine pushed a commit that referenced this pull request Nov 23, 2021
@levitte @DDvO
ERR: Add a missing common reason string
79ef187 
There was no string present for ERR_R_PASSED_INVALID_ARGUMENT

Reviewed-by: David von Oheimb <[email protected]>
(Merged from #17069)
baentsch added a commit to open-quantum-safe/openssl that referenced this pull request Jun 23, 2022
@baentsch @luyahan
@devnexen @davidben @t8m @paulidale @mattcaswell @levitte @ueno @ischwarze @bbbrumley @tmshort @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @beldmit @PeiweiHu @x2018 @allanjude @DDvO @dongbeiouba @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau @juergenchrist @reaperhulk @basavesh @frasertweedale
Upstream 111p merge (#375