Skip to content

Comments

Fix: invoking x509_name_cannon improperly#16974

Closed
PeiweiHu wants to merge 1 commit intoopenssl:masterfrom
PeiweiHu:PeiweiHu-Patch_1105
Closed

Fix: invoking x509_name_cannon improperly#16974
PeiweiHu wants to merge 1 commit intoopenssl:masterfrom
PeiweiHu:PeiweiHu-Patch_1105

Conversation

@PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Nov 5, 2021

x509_name_canon returns 0 for failure and 1 for success.

Checklist
  • documentation is added or updated
  • tests are added or updated

@t8m t8m added approval: review pending This pull request needs review by a committer branch: 3.0 Applies to openssl-3.0 branch branch: master Applies to master branch triaged: bug The issue/pr is/fixes a bug branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) labels Nov 5, 2021
@t8m
Copy link
Member

t8m commented Nov 5, 2021

OK for all branches.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 7, 2021
@paulidale
Copy link
Contributor

paulidale commented Nov 7, 2021

For all branches.

@openssl-machine
Copy link
Collaborator

openssl-machine commented Nov 9, 2021

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

openssl-machine pushed a commit that referenced this pull request Nov 9, 2021
@PeiweiHu @paulidale
Fix: invoking x509_name_cannon improperly
0923528 
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #16974)
openssl-machine pushed a commit that referenced this pull request Nov 9, 2021
@PeiweiHu @paulidale
Fix: invoking x509_name_cannon improperly
eaa76f4 
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #16974)

(cherry picked from commit 0923528)
openssl-machine pushed a commit that referenced this pull request Nov 9, 2021
@PeiweiHu @paulidale
Fix: invoking x509_name_cannon improperly
45838e5 
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #16974)

(cherry picked from commit 0923528)
@paulidale
Copy link
Contributor

paulidale commented Nov 9, 2021

Merged to all three branches. Thanks for the fix.

@paulidale paulidale closed this Nov 9, 2021
baentsch added a commit to open-quantum-safe/openssl that referenced this pull request Jun 23, 2022
@baentsch @luyahan
@devnexen @davidben @t8m @paulidale @mattcaswell @levitte @ueno @ischwarze @bbbrumley @tmshort @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @beldmit @PeiweiHu @x2018 @allanjude @DDvO @dongbeiouba @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau @juergenchrist @reaperhulk @basavesh @frasertweedale
Upstream 111p merge (#375