Skip to content

Comments

Fix a gcc 11.2.0 warning#16887

Closed
mattcaswell wants to merge 2 commits intoopenssl:masterfrom
mattcaswell:fix-gcc-warn
Closed

Fix a gcc 11.2.0 warning#16887
mattcaswell wants to merge 2 commits intoopenssl:masterfrom
mattcaswell:fix-gcc-warn

Conversation

@mattcaswell
Copy link
Member

@mattcaswell mattcaswell commented Oct 22, 2021

gcc 11.2.0 is the default on Ubuntu 21.10. It emits a (spurious) warning
when compiling test/packettest.c, which causes --strict-warnings builds
to fail. A simple fix avoids the warning.

@mattcaswell
Fix a gcc 11.2.0 warning
319d5c6 
gcc 11.2.0 is the default on Ubuntu 21.10. It emits a (spurious) warning
when compiling test/packettest.c, which causes --strict-warnings builds
to fail. A simple fix avoids the warning.
@mattcaswell mattcaswell added branch: master Applies to master branch approval: review pending This pull request needs review by a committer branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: 3.0 Applies to openssl-3.0 branch labels Oct 22, 2021
@mattcaswell
Copy link
Member Author

mattcaswell commented Oct 22, 2021

Ping? It would be nice to get this in. Its annoying.

beldmit
beldmit approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 22, 2021
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Oct 23, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 23, 2021

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Oct 23, 2021
paulidale
paulidale reviewed Oct 24, 2021
View reviewed changes
paulidale
paulidale requested changes Oct 24, 2021
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type concern ought to be fixed.

@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer and removed approval: ready to merge The 24 hour grace period has passed, ready to merge labels Oct 25, 2021
@mattcaswell
Copy link
Member Author

mattcaswell commented Oct 25, 2021

Fixup pushed addressing type issue. Please take a look.

@t8m t8m added approval: done This pull request has the required number of approvals triaged: bug The issue/pr is/fixes a bug and removed approval: review pending This pull request needs review by a committer labels Oct 25, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 26, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 26, 2021

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Oct 27, 2021
@mattcaswell
Fix a gcc 11.2.0 warning
37467b2 
gcc 11.2.0 is the default on Ubuntu 21.10. It emits a (spurious) warning
when compiling test/packettest.c, which causes --strict-warnings builds
to fail. A simple fix avoids the warning.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #16887)
openssl-machine pushed a commit that referenced this pull request Oct 27, 2021
@mattcaswell
Fix a gcc 11.2.0 warning
8121c0d 
gcc 11.2.0 is the default on Ubuntu 21.10. It emits a (spurious) warning
when compiling test/packettest.c, which causes --strict-warnings builds
to fail. A simple fix avoids the warning.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #16887)

(cherry picked from commit 37467b2)
openssl-machine pushed a commit that referenced this pull request Oct 27, 2021
@mattcaswell
Fix a gcc 11.2.0 warning
c03fa13 
gcc 11.2.0 is the default on Ubuntu 21.10. It emits a (spurious) warning
when compiling test/packettest.c, which causes --strict-warnings builds
to fail. A simple fix avoids the warning.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #16887)

(cherry picked from commit 37467b2)
@mattcaswell
Copy link
Member Author

mattcaswell commented Oct 27, 2021

Pushed to master, 3.0 and 1.1.1. Thanks.

baentsch added a commit to open-quantum-safe/openssl that referenced this pull request Jun 23, 2022
@baentsch @luyahan
@devnexen @davidben @t8m @paulidale @mattcaswell @levitte @ueno @ischwarze @bbbrumley @tmshort @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @beldmit @PeiweiHu @x2018 @allanjude @DDvO @dongbeiouba @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau @juergenchrist @reaperhulk @basavesh @frasertweedale