Skip to content

Comments

Fix test/recipes/01-test_symbol_presence.t to disregard version info#16840

Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
levitte:fix-16810-followup
Closed

Fix test/recipes/01-test_symbol_presence.t to disregard version info#16840
levitte wants to merge 1 commit intoopenssl:masterfrom
levitte:fix-16810-followup

Conversation

@levitte
Copy link
Member

@levitte levitte commented Oct 14, 2021

The output of 'nm -DPg' contains version info attached to the symbols,
which makes the test fail. Simply dropping the version info makes the
test work again.

Fixes #16810 (followup)

The output of 'nm -DPg' contains version info attached to the symbols,
which makes the test fail.  Simply dropping the version info makes the
test work again.

Fixes openssl#16810 (followup)
@levitte levitte added branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) labels Oct 14, 2021
@mattcaswell mattcaswell added the severity: urgent Fixes an urgent issue (exempt from 24h grace period) label Oct 14, 2021
@mattcaswell
Copy link
Member

Marked as urgent since this is breaking builds.

@levitte
Copy link
Member Author

levitte commented Oct 14, 2021

It's a bit interesting that the Github Actions builds didn't break...

@levitte levitte added the approval: done This pull request has the required number of approvals label Oct 14, 2021
openssl-machine pushed a commit that referenced this pull request Oct 14, 2021
The output of 'nm -DPg' contains version info attached to the symbols,
which makes the test fail.  Simply dropping the version info makes the
test work again.

Fixes #16810 (followup)

Reviewed-by: Matt Caswell <[email protected]>
(Merged from #16840)
openssl-machine pushed a commit that referenced this pull request Oct 14, 2021
The output of 'nm -DPg' contains version info attached to the symbols,
which makes the test fail.  Simply dropping the version info makes the
test work again.

Fixes #16810 (followup)

Reviewed-by: Matt Caswell <[email protected]>
(Merged from #16840)

(cherry picked from commit 73970cb)
openssl-machine pushed a commit that referenced this pull request Oct 14, 2021
The output of 'nm -DPg' contains version info attached to the symbols,
which makes the test fail.  Simply dropping the version info makes the
test work again.

Fixes #16810 (followup)

Reviewed-by: Matt Caswell <[email protected]>
(Merged from #16840)

(cherry picked from commit 73970cb)
@levitte
Copy link
Member Author

levitte commented Oct 14, 2021

Merged

master:
73970cb Fix test/recipes/01-test_symbol_presence.t to disregard version info

3.0:
4c60a96 Fix test/recipes/01-test_symbol_presence.t to disregard version info

1.1.1:
bf07844 Fix test/recipes/01-test_symbol_presence.t to disregard version info

@levitte levitte closed this Oct 14, 2021
@levitte levitte deleted the fix-16810-followup branch October 14, 2021 17:07
@levitte
Copy link
Member Author

levitte commented Oct 15, 2021

From observation, it seems that this fixes #16837, which I only noticed after I merged this PR.