Skip to content

Comments

Fix test/recipes/01-test_symbol_presence.t to allow for stripped libraries#16822

Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
levitte:fix-16810
Closed

Fix test/recipes/01-test_symbol_presence.t to allow for stripped libraries#16822
levitte wants to merge 1 commit intoopenssl:masterfrom
levitte:fix-16810

Conversation

@levitte
Copy link
Member

@levitte levitte commented Oct 13, 2021

It's a small change to the 'nm' call, to have it look at dynamic symbols
rather than the normal ones.

Fixes #16810

…aries

It's a small change to the 'nm' call, to have it look at dynamic symbols
rather than the normal ones.

Fixes openssl#16810
@levitte levitte added branch: 3.0 Applies to openssl-3.0 branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: master Applies to master branch labels Oct 13, 2021
@t8m t8m added triaged: bug The issue/pr is/fixes a bug approval: done This pull request has the required number of approvals labels Oct 13, 2021
@t8m
Copy link
Member

t8m commented Oct 13, 2021

The Windows CI failures are not relevant.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

openssl-machine pushed a commit that referenced this pull request Oct 14, 2021
…aries

It's a small change to the 'nm' call, to have it look at dynamic symbols
rather than the normal ones.

Fixes #16810

Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16822)
openssl-machine pushed a commit that referenced this pull request Oct 14, 2021
…aries

It's a small change to the 'nm' call, to have it look at dynamic symbols
rather than the normal ones.

Fixes #16810

Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16822)

(cherry picked from commit a85b4de)
openssl-machine pushed a commit that referenced this pull request Oct 14, 2021
…aries

It's a small change to the 'nm' call, to have it look at dynamic symbols
rather than the normal ones.

Fixes #16810

Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16822)

(cherry picked from commit a85b4de)
@levitte
Copy link
Member Author

levitte commented Oct 14, 2021

Merged

master:
a85b4de Fix test/recipes/01-test_symbol_presence.t to allow for stripped libraries

3.0:
1ca2bd4 Fix test/recipes/01-test_symbol_presence.t to allow for stripped libraries

1.1.1:
6b0f7a6 Fix test/recipes/01-test_symbol_presence.t to allow for stripped libraries