Skip to content

Comments

Fix some documentation errors#16794

Closed
PeiweiHu wants to merge 2 commits intoopenssl:masterfrom
PeiweiHu:PeiweiHu-Patch_1009_2
Closed

Fix some documentation errors#16794
PeiweiHu wants to merge 2 commits intoopenssl:masterfrom
PeiweiHu:PeiweiHu-Patch_1009_2

Conversation

@PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Oct 9, 2021

Checklist
  • documentation is added or updated
  • tests are added or updated

paulidale
paulidale reviewed Oct 10, 2021
View reviewed changes
doc/man3/ERR_load_strings.pod Outdated
=head1 RETURN VALUES

ERR_load_strings() returns no value. ERR_PACK() return the error code.
ERR_load_strings() returns 1 for success and 0 for failure. ERR_PACK() return the error code.
Copy link
Contributor

@paulidale paulidale Oct 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be: ERR_PACK() returns the error code.

Copy link
Contributor Author

@PeiweiHu PeiweiHu Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done√

@t8m t8m added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: 3.0 Applies to openssl-3.0 branch branch: master Applies to master branch triaged: documentation The issue/pr deals with documentation (errors) labels Oct 11, 2021
@t8m
Copy link
Member

t8m commented Oct 11, 2021

OK for all branches, where applicable.

@t8m t8m added the approval: review pending This pull request needs review by a committer label Oct 11, 2021
@PeiweiHu PeiweiHu requested a review from paulidale October 12, 2021 06:53
@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 21, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 22, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 22, 2021

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Oct 22, 2021
@PeiweiHu @t8m
Fix some documentation errors related to return values
f1d077f 
Reviewed-by: Shane Lontis <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16794)
openssl-machine pushed a commit that referenced this pull request Oct 22, 2021
@PeiweiHu @t8m
Fix some documentation errors related to return values
ef3889e 
Reviewed-by: Shane Lontis <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16794)

(cherry picked from commit f1d077f)
openssl-machine pushed a commit that referenced this pull request Oct 22, 2021
@PeiweiHu @t8m
Fix some documentation errors related to return values
851abe7 
Reviewed-by: Shane Lontis <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16794)

(cherry picked from commit f1d077f)
@t8m
Copy link
Member

t8m commented Oct 22, 2021

Merged to master, 3.0, and 1.1.1 branches. Thank you.

@t8m t8m closed this Oct 22, 2021
baentsch added a commit to open-quantum-safe/openssl that referenced this pull request Jun 23, 2022
@baentsch @luyahan
@devnexen @davidben @t8m @paulidale @mattcaswell @levitte @ueno @ischwarze @bbbrumley @tmshort @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @beldmit @PeiweiHu @x2018 @allanjude @DDvO @dongbeiouba @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau @juergenchrist @reaperhulk @basavesh @frasertweedale
Upstream 111p merge (#375