Skip to content

Comments

(Branch 1.1.1) Fix BIO_get_md_ctx return value check#16792

Closed
PeiweiHu wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
PeiweiHu:PeiweiHu-patch_1009
Closed

(Branch 1.1.1) Fix BIO_get_md_ctx return value check#16792
PeiweiHu wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
PeiweiHu:PeiweiHu-patch_1009

Conversation

@PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Oct 9, 2021

#16768

Checklist
  • documentation is added or updated
  • tests are added or updated

@t8m t8m added approval: review pending This pull request needs review by a committer branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) triaged: bug The issue/pr is/fixes a bug labels Oct 11, 2021
t8m
t8m approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for 1.1.1

slontis
slontis approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would say add blank lines (but this file is riddled with non blanklines)

@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 21, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 22, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 22, 2021

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Oct 22, 2021
@PeiweiHu @t8m
Fix BIO_get_md_ctx return value check
b28d41a 
Reviewed-by: Shane Lontis <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16792)
@t8m
Copy link
Member

t8m commented Oct 22, 2021

Merged to 1.1.1 branch. Thank you for your contribution.

@t8m t8m closed this Oct 22, 2021
baentsch added a commit to open-quantum-safe/openssl that referenced this pull request Jun 23, 2022
@baentsch @luyahan
@devnexen @davidben @t8m @paulidale @mattcaswell @levitte @ueno @ischwarze @bbbrumley @tmshort @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @beldmit @PeiweiHu @x2018 @allanjude @DDvO @dongbeiouba @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau @juergenchrist @reaperhulk @basavesh @frasertweedale
Upstream 111p merge (#375