Skip to content

Comments

Bindhost/bindport should be freed#16775

Closed
beldmit wants to merge 1 commit intoopenssl:masterfrom
beldmit:free_bindhostport
Closed

Bindhost/bindport should be freed#16775
beldmit wants to merge 1 commit intoopenssl:masterfrom
beldmit:free_bindhostport

Conversation

@beldmit
Copy link
Member

@beldmit beldmit commented Oct 7, 2021

When we allocate bindhost/bindport variables, we should free them.

Checklist
  • documentation is added or updated
  • tests are added or updated

@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer branch: 3.0 Applies to openssl-3.0 branch branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) labels Oct 7, 2021
@t8m t8m added the triaged: bug The issue/pr is/fixes a bug label Oct 8, 2021
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 8, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 9, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 9, 2021

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Oct 9, 2021
@beldmit
Bindhost/bindport should be freed
0ce0c45 
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16775)
openssl-machine pushed a commit that referenced this pull request Oct 9, 2021
@beldmit
Bindhost/bindport should be freed
cc51b5d 
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16775)

(cherry picked from commit 0ce0c45)
openssl-machine pushed a commit that referenced this pull request Oct 9, 2021
@beldmit
Bindhost/bindport should be freed
a653e03 
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16775)

(cherry picked from commit 0ce0c45)
@beldmit
Copy link
Member Author

beldmit commented Oct 9, 2021

Merged to all 3 branches

@beldmit beldmit closed this Oct 9, 2021
@beldmit
Copy link
Member Author

beldmit commented Oct 9, 2021

Thanks!

@beldmit beldmit deleted the free_bindhostport branch October 9, 2021 08:35
dstebila pushed a commit to open-quantum-safe/openssl that referenced this pull request Mar 15, 2022
@baentsch @levitte
@dongbeiouba @t8m @mattcaswell @NanXiao @yursha @mohd-akram @dcoombs @tmshort @paulidale @niclasr @slontis @tomato42 @beldmit @iguessthislldo @devnexen @bonniegong @kaduk @botovq @tiran @jpboivin @DDvO @p-steuer @goodpaperman @larsimmisch-adobe @luyahan @davidben @ueno @ischwarze @bbbrumley @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @PeiweiHu @x2018 @allanjude @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau
1.1.1n merge (#361