Skip to content

Comments

Fix unsafe BIO_get_md_ctx return value check#16768

Closed
PeiweiHu wants to merge 1 commit intoopenssl:masterfrom
PeiweiHu:PeiweiHu-Patch_1007_1
Closed

Fix unsafe BIO_get_md_ctx return value check#16768
PeiweiHu wants to merge 1 commit intoopenssl:masterfrom
PeiweiHu:PeiweiHu-Patch_1007_1

Conversation

@PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Oct 7, 2021

Checklist
  • documentation is added or updated
  • tests are added or updated

@t8m t8m added branch: master Applies to master branch triaged: bug The issue/pr is/fixes a bug labels Oct 7, 2021
@t8m t8m added branch: 3.0 Applies to openssl-3.0 branch approval: review pending This pull request needs review by a committer labels Oct 7, 2021
@mattcaswell mattcaswell added the branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) label Oct 7, 2021
mattcaswell
mattcaswell approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 1.1.1 label since it also seems to be an issue in that branch. @t8m are you ok with that backport?

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 7, 2021
@t8m
Copy link
Member

t8m commented Oct 7, 2021

Yes, OK, if it cherry-picks cleanly.

@Kps4444

This comment was marked as spam.

Sign in to view
@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 8, 2021

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 8, 2021
openssl-machine pushed a commit that referenced this pull request Oct 8, 2021
@PeiweiHu @t8m
Fix unsafe BIO_get_md_ctx check
59a3e7b 
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16768)
openssl-machine pushed a commit that referenced this pull request Oct 8, 2021
@PeiweiHu @t8m
Fix unsafe BIO_get_md_ctx check
4c09066 
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16768)

(cherry picked from commit 59a3e7b)
@t8m t8m removed the branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) label Oct 8, 2021
@t8m
Copy link
Member

t8m commented Oct 8, 2021

Merged to master and 3.0 branches. @PeiweiHu would you like to submit a pull request against the 1.1.1 branch? This unfortunately does not cherry pick cleanly to 1.1.1

@t8m t8m closed this Oct 8, 2021
@PeiweiHu
Copy link
Contributor Author

PeiweiHu commented Oct 8, 2021

Merged to master and 3.0 branches. @PeiweiHu would you like to submit a pull request against the 1.1.1 branch? This unfortunately does not cherry pick cleanly to 1.1.1

ok, I will do it later.

@PeiweiHu PeiweiHu mentioned this pull request Oct 9, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PeiweiHu @t8m @Kps4444 @openssl-machine @mattcaswell