Skip to content

Comments

Fix some possible memory leaks in EVP_CipherInit_ex#16756

Closed
bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
bernd-edlinger:fix_possible_memleaks_in_evp
Closed

Fix some possible memory leaks in EVP_CipherInit_ex#16756
bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
bernd-edlinger:fix_possible_memleaks_in_evp

Conversation

@bernd-edlinger
Copy link
Member

An EVP_CONTEXT with zero cipher but non-zero engine,
and/or cipher_data is possible if an error happens
in EVP_CTRL_INIT or in EVP_CTRL_COPY, the error handling
will just clear the cipher in that case.

This is for 1.1.1, master is broken differently...

An EVP_CONTEXT with zero cipher but non-zero engine,
and/or cipher_data is possible if an error happens
in EVP_CTRL_INIT or in EVP_CTRL_COPY, the error handling
will just clear the cipher in that case.
@bernd-edlinger bernd-edlinger added the branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) label Oct 6, 2021
@t8m t8m added the triaged: bug The issue/pr is/fixes a bug label Oct 6, 2021
@t8m t8m added the approval: done This pull request has the required number of approvals label Oct 6, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 7, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Oct 7, 2021
An EVP_CONTEXT with zero cipher but non-zero engine,
and/or cipher_data is possible if an error happens
in EVP_CTRL_INIT or in EVP_CTRL_COPY, the error handling
will just clear the cipher in that case.

Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16756)
@bernd-edlinger
Copy link
Member Author

Merged to 1.1.1 as 503eb0e. Thanks!