[WIP] Test with various crypto engines for 1.1.1#16750
Closed
bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Closed
[WIP] Test with various crypto engines for 1.1.1#16750bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Conversation
bernd-edlinger
added
the
branch: 1.1.1
Member
Author
|
this is WIP and contains the fix from #16751 otherwise it would not pass the CI tests, mostly on windows. |
bernd-edlinger
force-pushed
the
enable_crypto_engines_test_1
branch
from
d2b1bb5 to
b2bb98d
Compare
paulidale
reviewed
Nov 17, 2021
crypto/engine/eng_dyn.c
Outdated
Member
Author
There was a problem hiding this comment.
The error handling here is broken, if I simulate an error from ENGINE_add something terribly bad happens.
ENGINE_by_id start to return an invalid engine reference, but the caller does not know that it
should not use this engine for ENGINE_set_default(e, ENGINE_METHOD_ALL); and friends.
bernd-edlinger
force-pushed
the
enable_crypto_engines_test_1
branch
5 times, most recently
from
f51ab09 to
b0916da
Compare
Enable these crypto engines always when available: - afalg - padlock - dasync Where dasync will have lowest precedence.
bernd-edlinger
force-pushed
the
enable_crypto_engines_test_1
branch
from
b0916da to
774bee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable these crypto engines always when available: