Fix a memory leak in the afalg engine#16744
Closed
bernd-edlinger wants to merge 3 commits intoopenssl:masterfrom
Closed
Fix a memory leak in the afalg engine#16744bernd-edlinger wants to merge 3 commits intoopenssl:masterfrom
bernd-edlinger wants to merge 3 commits intoopenssl:masterfrom
Conversation
bernd-edlinger
added
branch: master
t8m
approved these changes
Oct 5, 2021
t8m
added
approval: done
Member
|
Would you please add the testcase from #16743 ? |
t8m
reviewed
Oct 5, 2021
| #endif | ||
|
|
||
|
|
||
| #ifndef OPENSSL_NO_AFALGENG |
Member
There was a problem hiding this comment.
I suppose this part should not be removed, or?
Member
Author
There was a problem hiding this comment.
this part is not necessary, so I removed it.
I tried with new kernel headers/old runtime kernel
and vice versa the test case is always passed.
ENGINE_by_id("afalg") != NULL should guarantee the engine is working.
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
t8m
approved these changes
Oct 6, 2021
t8m
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Oct 6, 2021
Fixes: #16743 Reviewed-by: Tomas Mraz <[email protected]> (Merged from #16744)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 6, 2021
Fixes: #16743 Reviewed-by: Tomas Mraz <[email protected]> (Merged from #16744) (cherry picked from commit 6f6a5e0)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 6, 2021
Fixes: #16743 Reviewed-by: Tomas Mraz <[email protected]> (Merged from #16744) (cherry picked from commit 6f6a5e0)
Member
Author
|
Merged to all branches. Thanks! |
dstebila
pushed a commit
to open-quantum-safe/openssl
that referenced
this pull request
Mar 15, 2022
Fixes: #16743