Skip to content

Comments

Fix a NPD bug in engines/e_dasync.c#16722

Closed
bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
bernd-edlinger:fix_pr7950
Closed

Fix a NPD bug in engines/e_dasync.c#16722
bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
bernd-edlinger:fix_pr7950

Conversation

@bernd-edlinger
Copy link
Member

@bernd-edlinger bernd-edlinger commented Sep 30, 2021

The dasync_aes_128_cbc_hmac_sha1 cipher depends on
EVP_aes_128_cbc_hmac_sha1() returning a NON-NULL value.
We should simply not advertise this cipher otherwise.

Fixes: #7950

@bernd-edlinger bernd-edlinger added the branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) label Sep 30, 2021
@bernd-edlinger
Fix a NPD bug in engines/e_dasync.c
b714a48 
The dasync_aes_128_cbc_hmac_sha1 cipher depends on
EVP_aes_128_cbc_hmac_sha1() returning a NON-NULL value.
We should simply not advertise this cipher otherwise.

Fixes: openssl#7950
t8m
t8m approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this apply to 3.0 and master as well?

@t8m t8m added approval: done This pull request has the required number of approvals triaged: bug The issue/pr is/fixes a bug labels Sep 30, 2021
@bernd-edlinger
Copy link
Member Author

bernd-edlinger commented Sep 30, 2021

Aehm, just in case you wanted to ask why this PR is not targeting master:
Engines are generally broken in master, but the dasync engine has another
null-pointer access in the RSA cipher, and unfortunately I have no idea how to fix that one.

@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 1, 2021

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@bernd-edlinger bernd-edlinger added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 1, 2021
openssl-machine pushed a commit that referenced this pull request Oct 1, 2021
@bernd-edlinger
Fix a NPD bug in engines/e_dasync.c
1be120a 
The dasync_aes_128_cbc_hmac_sha1 cipher depends on
EVP_aes_128_cbc_hmac_sha1() returning a NON-NULL value.
We should simply not advertise this cipher otherwise.

Fixes: #7950

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #16722)
@bernd-edlinger
Copy link
Member Author

bernd-edlinger commented Oct 1, 2021

Merged to 1.1.1 as 1be120a
Thanks!

dstebila pushed a commit to open-quantum-safe/openssl that referenced this pull request Mar 15, 2022
@baentsch @levitte
@dongbeiouba @t8m @mattcaswell @NanXiao @yursha @mohd-akram @dcoombs @tmshort @paulidale @niclasr @slontis @tomato42 @beldmit @iguessthislldo @devnexen @bonniegong @kaduk @botovq @tiran @jpboivin @DDvO @p-steuer @goodpaperman @larsimmisch-adobe @luyahan @davidben @ueno @ischwarze @bbbrumley @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @PeiweiHu @x2018 @allanjude @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau
1.1.1n merge (#361