Make version check in s_server DTLS aware#16709
Closed
Sean-Der wants to merge 1 commit intoopenssl:masterfrom
Sean-Der:master
Closed
Make version check in s_server DTLS aware#16709Sean-Der wants to merge 1 commit intoopenssl:masterfrom Sean-Der:master
Sean-Der wants to merge 1 commit intoopenssl:masterfrom
Sean-Der:master
Conversation
openssl-machine
added
the
hold: cla required
CLA: trivial Resolves #16707
openssl-machine
removed
the
hold: cla required
t8m
added
approval: review pending
t8m
approved these changes
Sep 30, 2021
Member
t8m
left a comment
t8m
left a comment
There was a problem hiding this comment.
LGTM. Good for all branches. I am also OK with CLA: trivial.
paulidale
reviewed
Sep 30, 2021
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
LGTM. Fine for all branched and agreed trivial.
@mattcaswell any thoughts?
paulidale
added
approval: done
kaduk
reviewed
Sep 30, 2021
Member
|
@paulidale Would you please formally approve? |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
Member
|
@paulidale ping |
mattcaswell
reviewed
Oct 15, 2021
| BIO_printf(bio_s_out, "psk_server_cb\n"); | ||
|
|
||
| if (SSL_version(ssl) >= TLS1_3_VERSION) { | ||
| if (SSL_version(ssl) >= TLS1_3_VERSION && SSL_version(ssl) < DTLS1_2_VERSION) { |
Member
There was a problem hiding this comment.
This should instead be checking SSL_is_dtls()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #16707