Skip to content

Comments

Clarify the documentation around session usage#16582

Closed
mattcaswell wants to merge 2 commits intoopenssl:masterfrom
mattcaswell:fix-session-docs
Closed

Clarify the documentation around session usage#16582
mattcaswell wants to merge 2 commits intoopenssl:masterfrom
mattcaswell:fix-session-docs

Conversation

@mattcaswell
Copy link
Member

@mattcaswell mattcaswell commented Sep 11, 2021

The documented behaviour for SSL_set_num_tickets() was not quite correct, and the behaviour of SSL_get_session() on the server side was not clear.

@mattcaswell
Correct the documentation for SSL_set_num_tickets()
ed51fac 
The behaviour for what happens in a resumption connection was not quite
described correctly.
@mattcaswell
Clarify what SSL_get_session() does on the server side in TLSv1.3
30c9b04
@mattcaswell mattcaswell added branch: master Applies to master branch approval: review pending This pull request needs review by a committer branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: 3.0 Applies to openssl-3.0 branch labels Sep 11, 2021
@mattcaswell mattcaswell mentioned this pull request Sep 11, 2021
Closed
@mattcaswell
Copy link
Member Author

mattcaswell commented Sep 11, 2021

See also issue #16576

@paulidale
Copy link
Contributor

paulidale commented Sep 13, 2021

Good for all three branches.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 13, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 14, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Sep 14, 2021

This pull request is ready to merge

@t8m t8m added the triaged: documentation The issue/pr deals with documentation (errors) label Sep 17, 2021
openssl-machine pushed a commit that referenced this pull request Sep 17, 2021
@mattcaswell @t8m
Correct the documentation for SSL_set_num_tickets()
4603b78 
The behaviour for what happens in a resumption connection was not quite
described correctly.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16582)
openssl-machine pushed a commit that referenced this pull request Sep 17, 2021
@mattcaswell @t8m
Clarify what SSL_get_session() does on the server side in TLSv1.3
9e51f87 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16582)
openssl-machine pushed a commit that referenced this pull request Sep 17, 2021
@mattcaswell @t8m
Clarify what SSL_get_session() does on the server side in TLSv1.3
2221e7e 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16582)

(cherry picked from commit 9e51f87)
openssl-machine pushed a commit that referenced this pull request Sep 17, 2021
@mattcaswell @t8m
Clarify what SSL_get_session() does on the server side in TLSv1.3
97a1fb5 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16582)

(cherry picked from commit 9e51f87)
openssl-machine pushed a commit that referenced this pull request Sep 17, 2021
@mattcaswell @t8m
Correct the documentation for SSL_set_num_tickets()
5402f96 
The behaviour for what happens in a resumption connection was not quite
described correctly.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16582)

(cherry picked from commit 4603b78)
openssl-machine pushed a commit that referenced this pull request Sep 17, 2021
@mattcaswell @t8m
Correct the documentation for SSL_set_num_tickets()
1199831 
The behaviour for what happens in a resumption connection was not quite
described correctly.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #16582)

(cherry picked from commit 4603b78)
@t8m
Copy link
Member

t8m commented Sep 17, 2021

Merged to master and cherry-picked the commits to both 3.0 and 1.1.1 branches. Thank you.

@t8m t8m closed this Sep 17, 2021
dstebila pushed a commit to open-quantum-safe/openssl that referenced this pull request Mar 15, 2022
@baentsch @levitte
@dongbeiouba @t8m @mattcaswell @NanXiao @yursha @mohd-akram @dcoombs @tmshort @paulidale @niclasr @slontis @tomato42 @beldmit @iguessthislldo @devnexen @bonniegong @kaduk @botovq @tiran @jpboivin @DDvO @p-steuer @goodpaperman @larsimmisch-adobe @luyahan @davidben @ueno @ischwarze @bbbrumley @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @PeiweiHu @x2018 @allanjude @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau
1.1.1n merge (#361