Skip to content

Comments

Fix nc_email to check ASN1 strings with NULL byte in the middle#16524

Closed
Roo4L wants to merge 1 commit intoopenssl:masterfrom
Roo4L:master
Closed

Fix nc_email to check ASN1 strings with NULL byte in the middle#16524
Roo4L wants to merge 1 commit intoopenssl:masterfrom
Roo4L:master

Conversation

@Roo4L
Copy link

@Roo4L Roo4L commented Sep 7, 2021

This fix is an addition to the sequence of commits fixing CVE-2021-3712

CLA: individual

@t8m t8m added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: 3.0 Applies to openssl-3.0 branch branch: master Applies to master branch triaged: bug The issue/pr is/fixes a bug approval: otc review pending labels Sep 7, 2021
@paulidale paulidale added approval: review pending This pull request needs review by a committer and removed approval: otc review pending labels Sep 8, 2021
Roo4L
Roo4L commented Sep 10, 2021
View reviewed changes
Copy link
Author

@Roo4L Roo4L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roo4L
Copy link
Author

Roo4L commented Sep 10, 2021

@paulidale sorry for a long response. I have misunderstood the meaning of "approval: review pending" label and didn't review at time.

@t8m
Copy link
Member

t8m commented Sep 12, 2021

I have misunderstood the meaning of "approval: review pending" label and didn't review at time.

No, I do not think your understanding was incorrect. One of the two required reviews must be done by a member of OTC and the second review must be done by a member of the OpenSSL committers group.

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 12, 2021
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Sep 13, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Sep 13, 2021

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Sep 13, 2021
openssl-machine pushed a commit that referenced this pull request Sep 13, 2021
@paulidale
Fix nc_email to check ASN1 strings with NULL byte in the middle
485d079 
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #16524)
openssl-machine pushed a commit that referenced this pull request Sep 13, 2021
@paulidale
Fix nc_email to check ASN1 strings with NULL byte in the middle
c247582 
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #16524)

(cherry picked from commit 485d079)
openssl-machine pushed a commit that referenced this pull request Sep 13, 2021
@paulidale
Fix nc_email to check ASN1 strings with NULL byte in the middle
9e44ffc 
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #16524)

(cherry picked from commit 485d079)
@paulidale
Copy link
Contributor

paulidale commented Sep 13, 2021

Merged to master, 3.0 and 1.1.1. Thanks for the contribution.

@paulidale paulidale closed this Sep 13, 2021
dstebila pushed a commit to open-quantum-safe/openssl that referenced this pull request Mar 15, 2022
@baentsch @levitte
@dongbeiouba @t8m @mattcaswell @NanXiao @yursha @mohd-akram @dcoombs @tmshort @paulidale @niclasr @slontis @tomato42 @beldmit @iguessthislldo @devnexen @bonniegong @kaduk @botovq @tiran @jpboivin @DDvO @p-steuer @goodpaperman @larsimmisch-adobe @luyahan @davidben @ueno @ischwarze @bbbrumley @ifranzki @romen @bernd-edlinger @uudiin @zhaozg @Dani-Hub @ellert @lprimak @mspncp @PeiweiHu @x2018 @allanjude @KanPlus @roussosalex @pkubaj @jmgdjgpp @Thomas1664 @JiangJias @faramir-dev @hlandau
1.1.1n merge (#361