Fix the "Out of memory" EVP KDF scrypt test#16444
Closed
bernd-edlinger wants to merge 2 commits intoopenssl:masterfrom
Closed
Fix the "Out of memory" EVP KDF scrypt test#16444bernd-edlinger wants to merge 2 commits intoopenssl:masterfrom
bernd-edlinger wants to merge 2 commits intoopenssl:masterfrom
Conversation
This test did not really execute, since usually the OPENSSL_malloc(0) will fail and prevent the execution of the KDF.
paulidale
reviewed
Aug 27, 2021
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
Hmmm, I thought malloc(0) was well defined. Still this is better.
paulidale
added
the
approval: done
Member
Author
|
I just thought, what if someone uses CRYPTO_set_mem_functions to override the default. |
t8m
approved these changes
Aug 27, 2021
paulidale
approved these changes
Aug 27, 2021
2 tasks
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 28, 2021
This test did not really execute, since usually the OPENSSL_malloc(0) will fail and prevent the execution of the KDF. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #16444)
Member
Author
|
Merged to master as cce935b. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test did not really execute, since usually
the OPENSSL_malloc(0) will fail and prevent the
execution of the KDF.
Checklist