Darwin platform allows to build on releases before Yosemite/ios 8.#16418
Closed
devnexen wants to merge 1 commit intoopenssl:masterfrom
Closed
Darwin platform allows to build on releases before Yosemite/ios 8.#16418devnexen wants to merge 1 commit intoopenssl:masterfrom
devnexen wants to merge 1 commit intoopenssl:masterfrom
Conversation
github-actions
bot
added
the
severity: fips change
t8m
approved these changes
Aug 25, 2021
t8m
added
approval: review pending
include/crypto/rand.h
Outdated
There was a problem hiding this comment.
Should the version number here be 101000?
Availability.h (in the MacOSX10.10 SDK) defines:
--snip--
#define __MAC_10_0 1000
#define __MAC_10_1 1010
#define __MAC_10_2 1020
#define __MAC_10_3 1030
#define __MAC_10_4 1040
#define __MAC_10_5 1050
#define __MAC_10_6 1060
#define __MAC_10_7 1070
#define __MAC_10_8 1080
#define __MAC_10_9 1090
#define __MAC_10_10 101000
#define __MAC_10_10_2 101002
#define __MAC_10_10_3 101003
--snip--
Contributor
Author
There was a problem hiding this comment.
true ... will update both PR.
devnexen
force-pushed
the
macos_old_releases
branch
from
8b72c4c to
f1a01d1
Compare
t8m
approved these changes
Aug 25, 2021
paulidale
approved these changes
Aug 25, 2021
paulidale
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 27, 2021
backport #16409 Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #16418)
Member
|
Merged to master. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #16409