Skip to content

Comments

[1.1.1][github-ci] Enable msan tests#16338

Closed
romen wants to merge 18 commits intoopenssl:OpenSSL_1_1_1-stablefrom
romen:issues/1.1.1/fix_incomplete_github_ci_p/msan
Closed

[1.1.1][github-ci] Enable msan tests#16338
romen wants to merge 18 commits intoopenssl:OpenSSL_1_1_1-stablefrom
romen:issues/1.1.1/fix_incomplete_github_ci_p/msan

Conversation

@romen
Copy link
Member

@romen romen commented Aug 17, 2021

This is based on #16252 and will need to be rebased once that is merged.

Tasks

  • Enable the tests again
  • Find ways to run this or change the comment in the tests to mark this disabled permanently
    • Ensure msan builds are run at least externally (buildbot or external run-checker runs)

romen added 12 commits August 14, 2021 15:01
This commit does not include the daily run-checker workflow.
The daily run-checker is scheduled to start at 6:42, instead of the
start of the hour.

The official GitHub documentation remarks the following regarding
scheduled workflows:

> Note: The schedule event can be delayed during periods of high loads
> of GitHub Actions workflow runs. High load times include the start of
> every hour. To decrease the chance of delay, schedule your workflow to
> run at a different time of the hour.

42, obviously, has been picked because it is the answer to the ultimate
question of life, the universe, and everything.
This commit temporarily disables cross-compiling tests for sparcv9, due
to failures to be investigated in a dedicated PR.
This commit temporarily disables krb5 external tests,
due to failures to be investigated in a dedicated PR.
This commit temporarily disables pyca external tests,
due to failures to be investigated in a dedicated PR.
This commit temporarily disables tests for no-tls1_3,
due to failures to be investigated in a dedicated PR.
In 1.1.1 currently we do not support running multiple tests in parallel,
and the `--debug -O1` msan build required more than 3h to run the tests.

This commit temporarily disables this build configuration.
This commit temporarily disables the ubsan build,
due to failures to be investigated in a dedicated PR.
@romen romen added the branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) label Aug 17, 2021
@romen romen self-assigned this Aug 17, 2021
@romen
Copy link
Member Author

romen commented Aug 17, 2021

@paulidale @levitte Any ideas on what we could try to get at least partial memory sanitizer builds covered? In Travis days we used to have something for 1.1.1 IIRC: can we work something out based on that?

@levitte how can I achieve the secondary goal of ensuring external 1.1.1 run-checker covers this? Can we do something buildbot based maybe which might have more resources/power to run these tests within reasonable limits?

@romen romen requested review from levitte and paulidale August 17, 2021 09:55
@romen romen mentioned this pull request Aug 17, 2021
16 tasks
@t8m t8m added the triaged: bug The issue/pr is/fixes a bug label Sep 17, 2021
@t8m t8m closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants