Skip to content

Comments

[1.1.1][github-ci] Fix ubsan tests#16337

Closed
romen wants to merge 14 commits intoopenssl:OpenSSL_1_1_1-stablefrom
romen:issues/1.1.1/fix_incomplete_github_ci_p/ubsan
Closed

[1.1.1][github-ci] Fix ubsan tests#16337
romen wants to merge 14 commits intoopenssl:OpenSSL_1_1_1-stablefrom
romen:issues/1.1.1/fix_incomplete_github_ci_p/ubsan

Conversation

@romen
Copy link
Member

@romen romen commented Aug 17, 2021

This is based on #16252 and will need to be rebased once that is merged.

Tasks

  • Enable the tests again
  • Fix the failure

romen added 12 commits August 14, 2021 15:01
This commit does not include the daily run-checker workflow.
The daily run-checker is scheduled to start at 6:42, instead of the
start of the hour.

The official GitHub documentation remarks the following regarding
scheduled workflows:

> Note: The schedule event can be delayed during periods of high loads
> of GitHub Actions workflow runs. High load times include the start of
> every hour. To decrease the chance of delay, schedule your workflow to
> run at a different time of the hour.

42, obviously, has been picked because it is the answer to the ultimate
question of life, the universe, and everything.
This commit temporarily disables cross-compiling tests for sparcv9, due
to failures to be investigated in a dedicated PR.
This commit temporarily disables krb5 external tests,
due to failures to be investigated in a dedicated PR.
This commit temporarily disables pyca external tests,
due to failures to be investigated in a dedicated PR.
This commit temporarily disables tests for no-tls1_3,
due to failures to be investigated in a dedicated PR.
In 1.1.1 currently we do not support running multiple tests in parallel,
and the `--debug -O1` msan build required more than 3h to run the tests.

This commit temporarily disables this build configuration.
This commit temporarily disables the ubsan build,
due to failures to be investigated in a dedicated PR.
@romen romen added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) triaged: bug The issue/pr is/fixes a bug labels Aug 17, 2021
@romen romen self-assigned this Aug 17, 2021
@romen romen mentioned this pull request Aug 17, 2021
16 tasks
romen added 2 commits August 17, 2021 13:27
This should be dropped before final merge, it is only meant to trigger
the execution of the tests within the PR.
@romen
Copy link
Member Author

romen commented Aug 17, 2021

Here is the verbose output for the outstanding failures: https://github.com/openssl/openssl/pull/16337/checks?check_run_id=3349544390

@levitte do you have suggestions on how to fix them?

@romen romen added the resolved: fixed This issue has been fixed label Aug 27, 2021
@romen
Copy link
Member Author

romen commented Aug 27, 2021

Closing this as @bernd-edlinger fixed it in #16423 .

@romen romen closed this Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) resolved: fixed This issue has been fixed triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant