Skip to content

Comments

[doc/man3] documentation: BN_cmp manpage updates#16214

Closed
bbbrumley wants to merge 2 commits intoopenssl:masterfrom
bbbrumley:bbb_docabs
Closed

[doc/man3] documentation: BN_cmp manpage updates#16214
bbbrumley wants to merge 2 commits intoopenssl:masterfrom
bbbrumley:bbb_docabs

Conversation

@bbbrumley
Copy link
Contributor

@bbbrumley bbbrumley commented Aug 4, 2021

Working on some code and noticed BN_abs_is_word documentation is missing. Been there forever.

These functions also aren't macros anymore.

@romen romen added approval: review pending This pull request needs review by a committer branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: master Applies to master branch triaged: documentation The issue/pr deals with documentation (errors) labels Aug 4, 2021
romen
romen approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@romen romen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for helping taking care of our documentation! PRs like this are often underrated, but they are extremely valuable!

paulidale
paulidale reviewed Aug 4, 2021
View reviewed changes
@romen
Copy link
Member

romen commented Aug 4, 2021

This should apply to 1.1.1 as well.

paulidale
paulidale approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 4, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 5, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Aug 5, 2021

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Aug 5, 2021
@bbbrumley @beldmit
[doc/man3] documentation: BN_cmp manpage updates
3d4ca44 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Nicola Tuveri <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #16214)
@beldmit
Copy link
Member

beldmit commented Aug 5, 2021

Merged. Many thanks for your contribution!

@beldmit beldmit closed this Aug 5, 2021
openssl-machine pushed a commit that referenced this pull request Aug 5, 2021
@bbbrumley @beldmit
[doc/man3] documentation: BN_cmp manpage updates
5b31b9d 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Nicola Tuveri <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #16214)

(cherry picked from commit 3d4ca44)
dstebila added a commit to open-quantum-safe/openssl that referenced this pull request Aug 26, 2021
@dstebila @mattcaswell
@NanXiao @t8m @sebastianas @richsalz @levitte @ischwarze @devnexen @DDvO @oleavr @anupamam13 @bbbrumley @tmshort @beldmit @tim-hitchins-ekkosense @mspncp @arminfuerst @bernd-edlinger @jay @kaduk @bsdjhb @zjd87 @jwalch @mszabo @romen @mamapanda @paulidale @dongbeiouba @yursha @mohd-akram @dcoombs @niclasr @slontis @tomato42 @iguessthislldo @bonniegong @botovq @tiran @jpboivin @p-steuer @goodpaperman @larsimmisch-adobe @luyahan @davidben @ueno @ifranzki
Update to OpenSSL 1.1.1l (#330