Fix some minor record layer issues [1.1.1]#16105
Closed
kaduk wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Closed
Fix some minor record layer issues [1.1.1]#16105kaduk wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
kaduk wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Conversation
Various comments referred to s->packet and s->packet_length instead of s->rlayer.packet and s->rlayer.packet_length. Also fixed is a spot where RECORD_LAYER_write_pending() should have been used. Based on the review comments in openssl#16077. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Ben Kaduk <[email protected]> (Merged from openssl#16086) (cherry picked from commit ca00152)
paulidale
approved these changes
Jul 19, 2021
paulidale
added
approval: done
Member
|
So this is just fixing the comments, but OK anyway. |
t8m
approved these changes
Jul 19, 2021
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
Contributor
|
Merged to 1.1.1, thanks. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 20, 2021
Various comments referred to s->packet and s->packet_length instead of s->rlayer.packet and s->rlayer.packet_length. Also fixed is a spot where RECORD_LAYER_write_pending() should have been used. Based on the review comments in #16077. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Ben Kaduk <[email protected]> (cherry picked from commit ca00152) Reviewed-by: Paul Dale <[email protected]> (Merged from #16105)
dstebila
added a commit
to open-quantum-safe/openssl
that referenced
this pull request
Aug 26, 2021
Backport #16086 to 1.1.1.
Two chunks didn't apply cleanly: one due to
ssl3_state_stbeing a separate allocation in 1.1.1 (but the fields being described are no longer in that structure anyway), and one due toSSL_new_session_ticket()not existing on 1.1.1.