Add testcases for SSL_key_update problems#16085
Closed
hou2gou wants to merge 1 commit intoopenssl:masterfrom
Closed
Add testcases for SSL_key_update problems#16085hou2gou wants to merge 1 commit intoopenssl:masterfrom
hou2gou wants to merge 1 commit intoopenssl:masterfrom
Conversation
Member
|
Could you please reword the commit message a little bit? |
hou2gou
changed the title
hou2gou
changed the title
t8m
requested changes
Jul 15, 2021
mattcaswell
requested changes
Jul 15, 2021
Contributor
Author
|
I have changed the early review opinions, I can't understand what meaning is outdated? |
Contributor
github says that the review comment is "outdated" when the comment was made on a version of the code (or, in this case, documentation) that is not the current version of the pull request. In that sense the comment is "out of date", and thus "outdated". |
Test that SSL_key_update() is not allowed if there are writes pending. Test that there is no reset of the packet pointer in ssl3_setup_read_buffer().
t8m
approved these changes
Jul 19, 2021
t8m
added
approval: review pending
paulidale
approved these changes
Jul 20, 2021
paulidale
added
approval: done
t8m
approved these changes
Jul 20, 2021
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Contributor
|
Merged, thanks for this. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 21, 2021
Test that SSL_key_update() is not allowed if there are writes pending. Test that there is no reset of the packet pointer in ssl3_setup_read_buffer(). Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #16085)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add testcases for SSL_key_update() corner case calls
Test that SSL_key_update() is not allowed if there are writes pending.
Test that there is no reset of the packet pointer in ssl3_setup_read_buffer().
Fix #16077
Discuss #16021