Avoid empty lines in nmake rule bodies [master]#16048
Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
Closed
Avoid empty lines in nmake rule bodies [master]#16048levitte wants to merge 1 commit intoopenssl:masterfrom
levitte wants to merge 1 commit intoopenssl:masterfrom
Conversation
nmake is tolerant of those empty lines, but jom isn't. That tolerance isn't standard make behaviour, so we lean towards avoiding them. We simply use '@Rem' instead. Fixes openssl#16014
levitte
added
branch: master
Member
Author
|
Corresponding fix for 1.1.1 in #16047 |
paulidale
approved these changes
Jul 12, 2021
paulidale
added
approval: done
t8m
approved these changes
Jul 13, 2021
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 13, 2021
nmake is tolerant of those empty lines, but jom isn't. That tolerance isn't standard make behaviour, so we lean towards avoiding them. We simply use '@Rem' instead. Fixes #16014 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #16048)
Member
Author
|
Merged 53111a8 Avoid empty lines in nmake rule bodies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nmake is tolerant of those empty lines, but jom isn't. That tolerance
isn't standard make behaviour, so we lean towards avoiding them.
We simply use '@Rem' instead.
Fixes #16014