Skip to content

Comments

BIO_lookup_ex: use AI_ADDRCONFIG only if explicit host name is given [1.1.1]#16039

Closed
ueno wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
ueno:wip/dueno/addrconfig-1.1.1
Closed

BIO_lookup_ex: use AI_ADDRCONFIG only if explicit host name is given [1.1.1]#16039
ueno wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
ueno:wip/dueno/addrconfig-1.1.1

Conversation

@ueno
Copy link
Contributor

@ueno ueno commented Jul 9, 2021

Backport of #16033 to the 1.1.1 branch.

Checklist
  • documentation is added or updated
  • tests are added or updated

@ueno
BIO_lookup_ex: use AI_ADDRCONFIG only if explicit host name is given
009a65f 
The flag only affects which record types are queried via DNS (A or
AAAA, or both).  When node is NULL and AF_UNSPEC is used, it prevents
getaddrinfo returning the right address associated with the loopback
interface.

Signed-off-by: Daiki Ueno <[email protected]>
beldmit
beldmit approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: otc review pending branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) labels Jul 9, 2021
@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: otc review pending labels Jul 12, 2021
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Jul 13, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Jul 13, 2021

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Jul 13, 2021
@paulidale
Copy link
Contributor

paulidale commented Jul 13, 2021

Merged to 1.1.1. Thanks for the backport.

@paulidale paulidale closed this Jul 13, 2021
openssl-machine pushed a commit that referenced this pull request Jul 13, 2021
@ueno @paulidale
BIO_lookup_ex: use AI_ADDRCONFIG only if explicit host name is given
474cd19 
The flag only affects which record types are queried via DNS (A or
AAAA, or both).  When node is NULL and AF_UNSPEC is used, it prevents
getaddrinfo returning the right address associated with the loopback
interface.

Signed-off-by: Daiki Ueno <[email protected]>

Reviewed-by: Dmitry Belyavskiy <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #16039)
dstebila added a commit to open-quantum-safe/openssl that referenced this pull request Aug 26, 2021
@dstebila @mattcaswell
@NanXiao @t8m @sebastianas @richsalz @levitte @ischwarze @devnexen @DDvO @oleavr @anupamam13 @bbbrumley @tmshort @beldmit @tim-hitchins-ekkosense @mspncp @arminfuerst @bernd-edlinger @jay @kaduk @bsdjhb @zjd87 @jwalch @mszabo @romen @mamapanda @paulidale @dongbeiouba @yursha @mohd-akram @dcoombs @niclasr @slontis @tomato42 @iguessthislldo @bonniegong @botovq @tiran @jpboivin @p-steuer @goodpaperman @larsimmisch-adobe @luyahan @davidben @ueno @ifranzki
Update to OpenSSL 1.1.1l (#330