in the evppkey_sm2.txt, it does not set random data, and it is not better to do the encryption and decryption.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

I have to submit the ICLA and CCLA.

close/reopen to re-trigger the CLA check

It seems the CLA check is still failing. @mattcaswell can you check this?

How to change the email to the [email protected]!

How to change the email to the [email protected]!

You can edit your personal e-mail address(es) at https://github.com/settings/emails .

How to change the email to the [email protected]!

You can edit your personal e-mail address(es) at https://github.com/settings/emails .

How to change the email to the [email protected]!

You can edit your personal e-mail address(es) at https://github.com/settings/emails .

Your settings look good. Did set them just now or where they already set like this?

uncheck it! and what next... I have tried some ways, but not correct.

Changing the author email of an existing commit is not supported by the GitHub web interface. It needs to be done locally using the git commandline tool. Your pull request branch needs to be rebased anyway, because you have a merge commit from master, 975845d5c5f0881863be2493a7b91358d2ab3fad, which we don't allow.

If you want, I can do the rebase and force-push it to your remote branch. All you need to do then is to reset your local branch. Please let me know if you wan't me to do it.

I found your email address twice in the git log. If you want me to reset the author address of your commits, which of the two versions do you want me to use?

Author: Mingjun.Yang <[email protected]>
Author: 杨明君 <[email protected]>

Changing the author email of an existing commit is not supported by the GitHub web interface. It needs to be done locally using the git commandline tool. Your pull request branch needs to be rebased anyway, because you have a merge commit from master, 975845d, which we don't allow.

If you wan't, I can do the rebase and force-push it to your remote branch. All you need to do then is to reset your local branch. Please let me know if you wan't me to do it.

thanks! you can rebase my branch.

Mingjun.Yang [email protected]

Mingjun.Yang [email protected]

this one.

There is a merge conflict in test_sm2_crypt(). Variant A is on 'master', variant B on your branch. What is the correct merged version?

<<<<<<< variant A
    if (!TEST_true(ossl_sm2_plaintext_size(ctext, ctext_len, &ptext_len))
            || !TEST_int_eq(ptext_len, msg_len))
>>>>>>> variant B
    if (!TEST_true(ossl_sm2_plaintext_size(key, digest, ctext_len, &ptext_len))
            || !TEST_int_ge(ptext_len, msg_len))
####### Ancestor
    if (!TEST_true(ossl_sm2_plaintext_size(key, digest, ctext_len, &ptext_len))
            || !TEST_int_eq(ptext_len, msg_len))
======= end

I guess it's

    if (!TEST_true(ossl_sm2_plaintext_size(ctext, ctext_len, &ptext_len))
            || !TEST_int_ge(ptext_len, msg_len))

but I'm not sure.

if (!TEST_true(ossl_sm2_plaintext_size(ctext, ctext_len, &ptext_len))
|| !TEST_int_eq(ptext_len, msg_len))

please keep the origianl version!
if (!TEST_true(ossl_sm2_plaintext_size(ctext, ctext_len, &ptext_len))
|| !TEST_int_eq(ptext_len, msg_len))

During uploading my codes, the api is changed! so I fixed it.

I rebased your branch and squashed the fixups into a single commit. Please reset your local branch and check the result.

You just overwrote my changes with your force-push. I am going to force-push again...

Sorry, something changed, I don't seem to have the permission to push to your branch anymore.

Maybe it's better if you close this pr and open a new one? You find my rebased and squashed commit at bc37353a3649bd42e2c7b80a760fe55023812328.

I recommend that you create a topic branch for your pull request and don't reuse the 'master' branch of your fork.

@mspncp I open a new one.

Closed in favour of #16511