Modify ssl_handshake_hash to call SSLfatal#15520
Closed
trevorlarock wants to merge 1 commit intoopenssl:masterfrom
trevorlarock:master
Closed
Modify ssl_handshake_hash to call SSLfatal#15520trevorlarock wants to merge 1 commit intoopenssl:masterfrom trevorlarock:master
trevorlarock wants to merge 1 commit intoopenssl:masterfrom
trevorlarock:master
Conversation
openssl-machine
added
the
hold: cla required
When EVP_MD_CTX_new fails call SSLfatal before the goto err. This resolves a state machine issue on the out of memory condition. Fixes #15491. CLA: trivial
openssl-machine
removed
the
hold: cla required
kaduk
approved these changes
May 31, 2021
kaduk
added
approval: otc review pending
branch: master
t8m
approved these changes
May 31, 2021
Member
|
I am OK with CLA: trivial although it is borderline. |
t8m
added
approval: done
Member
|
@kaduk please confirm, you're OK with CLA: trivial for this change. |
Contributor
|
Yes, this is clearly trivial, as the openssl style guide and |
Contributor
paulidale
approved these changes
Jun 1, 2021
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
t8m
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Jun 1, 2021
When EVP_MD_CTX_new fails call SSLfatal before the goto err. This resolves a state machine issue on the out of memory condition. Fixes #15491. CLA: trivial Reviewed-by: Ben Kaduk <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #15520)
Member
|
Merged to master. Thank you for the contribution. |
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
When EVP_MD_CTX_new fails call SSLfatal before the goto err. This resolves a state machine issue on the out of memory condition. Fixes openssl#15491. CLA: trivial Reviewed-by: Ben Kaduk <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#15520)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When EVP_MD_CTX_new fails call SSLfatal before the goto err.
This resolves a state machine issue on the out of memory condition.
Fixes #15491.