Skip to content

Comments

Add ordinal numbers to the .num files#15384

Closed
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
mattcaswell:make-update-beta1dev
Closed

Add ordinal numbers to the .num files#15384
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
mattcaswell:make-update-beta1dev

Conversation

@mattcaswell
Copy link
Member

Now that our next release is expected to be a beta release, "make update"
wants to see ordinal numbers in the .num files.

Run make update to add them.

Marking this as urgent because it is causing CI runs to fail.

Now that our next release is expected to be a beta release, "make update"
wants to see ordinal numbers in the .num files.

Run make update to add them.
@mattcaswell mattcaswell added branch: master Applies to master branch approval: review pending This pull request needs review by a committer severity: urgent Fixes an urgent issue (exempt from 24h grace period) labels May 20, 2021
@levitte levitte added approval: done This pull request has the required number of approvals approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: review pending This pull request needs review by a committer approval: done This pull request has the required number of approvals labels May 20, 2021
@levitte
Copy link
Member

levitte commented May 20, 2021

... and the game is on...

@mattcaswell
Copy link
Member Author

Errr... @levitte you added the "ready to merge" label but didn't click "approve". I'm assuming this is approved???

Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now

(oops)

openssl-machine pushed a commit that referenced this pull request May 20, 2021
Now that our next release is expected to be a beta release, "make update"
wants to see ordinal numbers in the .num files.

Run make update to add them.

Reviewed-by: Richard Levitte <[email protected]>
(Merged from #15384)
@mattcaswell
Copy link
Member Author

Pushed. Thanks.

devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
Now that our next release is expected to be a beta release, "make update"
wants to see ordinal numbers in the .num files.

Run make update to add them.

Reviewed-by: Richard Levitte <[email protected]>
(Merged from openssl#15384)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants