Replace some of the ERR_clear_error() calls in libcrypto with mark calls#15253
Closed
t8m wants to merge 1 commit intoopenssl:masterfrom
Closed
Replace some of the ERR_clear_error() calls in libcrypto with mark calls#15253t8m wants to merge 1 commit intoopenssl:masterfrom
t8m wants to merge 1 commit intoopenssl:masterfrom
Conversation
t8m
added
approval: review pending
levitte
approved these changes
May 12, 2021
levitte
added
approval: done
paulidale
approved these changes
May 13, 2021
slontis
approved these changes
May 13, 2021
Member
slontis
left a comment
slontis
left a comment
There was a problem hiding this comment.
I realize we have run out of time - but test coverage for these would probably be a good idea at some point.
t8m
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
May 13, 2021
Fixes #15219 Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Shane Lontis <[email protected]> (Merged from #15253)
Member
Author
|
Merged to master. Thank you for the reviews. |
Contributor
|
I'm astonished to see how simple it was to solve #15219 👍 |
Contributor
|
This change revealed some spurious error queue entries in OSSL_STORE when loading private keys, e.g., I'll try to come up with a fix. |
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
Fixes openssl#15219 Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Shane Lontis <[email protected]> (Merged from openssl#15253)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15219
This does not replace all of them as removal of some of the ERR_clear_error() would require more substantial changes or might be potentially a security problem.