Fix memory leak in d2i_ASN1_OBJECT.#14952
Closed
slontis wants to merge 1 commit intoopenssl:masterfrom
Closed
Conversation
Fixes openssl#14667 Added fix supplied by @levitte in PR openssl#14938 Reworked test supplied by @smcpeak into a unit test.
slontis
added
branch: master
paulidale
approved these changes
Apr 21, 2021
paulidale
added
approval: done
Member
|
Are you saying we should not have the test in 1.1.1? |
Member
Author
I don't mind either way... Kill this PR and add the test to your PR if you want. |
Member
Okie. |
Member
|
Now cherry-picked. Thanks for coding that test! |
Member
Author
|
Thanks @smcpeak for supplying a testcase - it makes it much easier to add a test when someone goes to the trouble of doing that.. |
Contributor
|
You're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14667
Added fix supplied by @levitte in PR #14938
Reworked test supplied by @smcpeak into a unit test.
Tested via valgrind before and after the fix was added.
@levitte I just created a separate PR that was based against master branch (not 111).
Checklist