Github workflows: re-implement a no-shared build#14753
Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
Closed
Github workflows: re-implement a no-shared build#14753levitte wants to merge 1 commit intoopenssl:masterfrom
levitte wants to merge 1 commit intoopenssl:masterfrom
Conversation
levitte
added
branch: master
Member
|
And now you have to solve the duplicate symbols problem. |
Member
Author
|
So I guess it's time to resurrect #11311 |
Closed
Member
Author
|
Re-created in #14755 |
Member
Author
|
For testing purposes, I've a merge of this and #14755 in https://github.com/levitte/openssl/tree/fix-11281%2B%2Bworkflow-reimplement-no-shared |
slontis
approved these changes
Apr 1, 2021
Member
slontis
left a comment
slontis
left a comment
There was a problem hiding this comment.
This is good to go when the dependancy is fixed..
Try not to add too many more macos builds if we can help it..
We do this both on Ubuntu and MacOS X
levitte
force-pushed
the
workflow-reimplement-no-shared
branch
from
7f4deec to
5c79efe
Compare
Member
Author
|
Rebased just to prove that it now builds without failure |
slontis
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 15, 2021
We do this both on Ubuntu and MacOS X Reviewed-by: Shane Lontis <[email protected]> (Merged from #14753)
Member
Author
|
Merged 4a95b70 Github workflows: re-implement a no-shared build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do this both on Ubuntu and MacOS X