Conversation
21d25e4 to
c225691
Compare
|
Eventually this could become part of a matrix in CI.yml. But for now just get it to build.. Note that mac consumes lots more minutes resources (10 * ??).. |
|
Another way would be this: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 85fbe952dc..18a700438c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -71,7 +71,10 @@ jobs:
run: make test HARNESS_JOBS=${HARNESS_JOBS:-4}
minimal:
- runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ os: [ ubuntu-latest, macos-latest ]
+ runs-on: ${{matrix.os}}
steps:
- uses: actions/checkout@v2
- name: configA positive thing with this is that if it doesn't build on one of the listed operating systems, builds on the remaining ones are automatically cancelled. |
|
I do not think we would want to run many different builds on MacOSX but the minimal build is really too limited. I suppose doing the basic possibly with an additional install phase would be sufficient? |
Sounds good to me |
|
I will add it to the out-of-source-and-install |
c225691 to
ff340a8
Compare
|
Do you plan to add it elsewhere in this PR, or is it time for final review? |
|
This looked like a good place to add it - without having too many macos builds being kicked off. |
|
It is good enough |
|
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #14738)
|
Thanks for the input.. Merged to master. |
Checklist