Skip to content

Comments

Add riscv64 target#14723

Closed
luyahan wants to merge 2 commits intoopenssl:masterfrom
luyahan:master
Closed

Add riscv64 target#14723
luyahan wants to merge 2 commits intoopenssl:masterfrom
luyahan:master

Conversation

@luyahan
Copy link
Contributor

@luyahan luyahan commented Mar 29, 2021

Just only add riscv64 config for no-asm.

@luyahan luyahan mentioned this pull request Mar 29, 2021
Closed
@levitte levitte added approval: review pending This pull request needs review by a committer branch: master Applies to master branch cla: trivial One of the commits is marked as 'CLA: trivial' labels Mar 29, 2021
@levitte
Copy link
Member

levitte commented Mar 29, 2021

Formality: I agree this is trivial

t8m
t8m requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I am not quite sure about the CLA: trivial.

Citing our CLA policy:
A submission is trivial if it is considered trivial under copyright law. Since we are not lawyers, we place the bar for trivial contributions very high. For example: corrections of grammatical or typographical errors (including misspelled function names in manual pages), simple whitespace changes and in some cases one-line bugfixes might be accepted as trivial without requiring a CLA.
This seems to be a bit more than just one-line bug fix.

@levitte
Copy link
Member

levitte commented Mar 29, 2021

Also I am not quite sure about the CLA: trivial.

Okie. @luyahan, would you mind submitting a CLA, then?

@luyahan
Copy link
Contributor Author

luyahan commented Mar 30, 2021

Also I am not quite sure about the CLA: trivial.

Okie. @luyahan, would you mind submitting a CLA, then?

OK,i will to try sign it. Thanks

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Mar 30, 2021
@luyahan
Copy link
Contributor Author

luyahan commented Mar 30, 2021 •
edited
Loading

Also I am not quite sure about the CLA: trivial.

Okie. @luyahan, would you mind submitting a CLA, then?

I have sended a email with signed pdf file to [email protected]

@luyahan luyahan requested a review from t8m March 30, 2021 06:35
@levitte
Copy link
Member

levitte commented Mar 30, 2021

CLA taken care of. I'll close and re-open this PR to kick the checker into action

@levitte levitte closed this Mar 30, 2021
@levitte levitte reopened this Mar 30, 2021
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Mar 30, 2021
@levitte levitte removed the cla: trivial One of the commits is marked as 'CLA: trivial' label Mar 30, 2021
t8m
t8m reviewed Mar 30, 2021
View reviewed changes
@luyahan luyahan requested a review from t8m March 31, 2021 02:16
@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 31, 2021
@openssl-machine
Copy link
Collaborator

openssl-machine commented Apr 1, 2021

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

openssl-machine pushed a commit that referenced this pull request Apr 1, 2021
@luyahan @t8m
Add riscv64 target
c295542 
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #14723)
@t8m
Copy link
Member

t8m commented Apr 1, 2021

Merged to master branch. Thank you for the contribution!

@t8m t8m closed this Apr 1, 2021
@slontis slontis mentioned this pull request Apr 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levitte levitte levitte approved these changes

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luyahan @levitte @openssl-machine @t8m @paulidale