Various cleanups related to EVP_PKEY_CTX_ctrl related TODOs#14290
Closed
t8m wants to merge 6 commits intoopenssl:masterfrom
Closed
Various cleanups related to EVP_PKEY_CTX_ctrl related TODOs#14290t8m wants to merge 6 commits intoopenssl:masterfrom
t8m wants to merge 6 commits intoopenssl:masterfrom
Conversation
t8m
added
branch: master
2 tasks
levitte
reviewed
Feb 23, 2021
levitte
reviewed
Feb 23, 2021
levitte
reviewed
Feb 23, 2021
levitte
approved these changes
Feb 23, 2021
levitte
added
approval: done
paulidale
approved these changes
Feb 23, 2021
t8m
force-pushed
the
pkey-ctrl-cleanups
branch
from
8e8f54f to
a1744a5
Compare
Member
Author
|
Rebased to fix trivial conflict in crypto/evp/dh_ctrl.c. Still approved? |
t8m
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Feb 24, 2021
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #14290)
openssl-machine
pushed a commit
that referenced
this pull request
Feb 24, 2021
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #14290)
openssl-machine
pushed a commit
that referenced
this pull request
Feb 24, 2021
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #14290)
openssl-machine
pushed a commit
that referenced
this pull request
Feb 24, 2021
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #14290)
Member
Author
|
As the rebase was trivial I did not feel we need to restart the timeout for ready to merge. Merged to master. Thank you for the reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is picking up useful changes from the PR #12998