Improve ossl_cmp_build_cert_chain() and export as X509_build_chain()#14128
Closed
DDvO wants to merge 1 commit intoopenssl:masterfrom
Closed
Improve ossl_cmp_build_cert_chain() and export as X509_build_chain()#14128DDvO wants to merge 1 commit intoopenssl:masterfrom
DDvO wants to merge 1 commit intoopenssl:masterfrom
Conversation
2 tasks
richsalz
reviewed
Feb 8, 2021
DDvO
changed the title
DDvO
force-pushed
the
add_OSSL_build_cert_chain
branch
3 times, most recently
from
712d2e1 to
418c51d
Compare
DDvO
force-pushed
the
add_OSSL_build_cert_chain
branch
from
418c51d to
f4b8649
Compare
Contributor
Author
|
Rebased to solve merge conflicts. |
DDvO
force-pushed
the
add_OSSL_build_cert_chain
branch
from
f4b8649 to
bc98cdc
Compare
Contributor
Author
|
Rebased and carved out |
DDvO
changed the title
DDvO
force-pushed
the
add_OSSL_build_cert_chain
branch
from
bc98cdc to
e11d286
Compare
Collaborator
|
This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago |
Contributor
Author
|
Can we please finalize this soon? Note that this just adds a new API element and does not affect cert (chain) validation. |
t8m
approved these changes
Apr 19, 2021
t8m
added
approval: done
Contributor
Author
|
Pushed - thanks @t8m! |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 20, 2021
Reviewed-by: Tomas Mraz <[email protected]> (Merged from #14128)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far there was no efficient way of using the OpenSSL API to just build the chain of a given cert without attempting to verify it.
Add
X509_build_chain()to fill this gap.This has been carved out from #13748.
Checklist